Decouple build feature code - #838
Merged
xiaoyongzhu merged 8 commits intoNov 23, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
xiaoyongzhu
requested review from
Yuqing-cat,
blrchen,
edwincheung,
enya-yx,
hangfei,
jainr,
jaymo001 and
windoze
November 7, 2022 09:37
xiaoyongzhu
commented
Nov 7, 2022
Comment thread
feathr_project/feathr/client.py
Outdated
aabbasi-hbo
reviewed
Nov 7, 2022
Comment thread
feathr_project/feathr/registry/_feathr_registry_client.py
Yuqing-cat
reviewed
Nov 8, 2022
Comment thread
feathr_project/feathr/client.py
Yuqing-cat
reviewed
Nov 23, 2022
Yuqing-cat
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good to me, add some comments.
Sorry, something went wrong.
Comment thread
feathr_project/feathr/definition/config_helper.py
Outdated
Comment thread
feathr_project/feathr/client.py
Comment thread
feathr_project/feathr/definition/config_helper.py
Yuqing-cat
approved these changes
Nov 23, 2022
blrchen
approved these changes
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR decouples the save_to_feature_config_from_context method from the registry code, given:
How was this PR tested?
Does this PR introduce any user-facing changes?