Fix auto-tz casting bug - #905
Merged
bozhonghu merged 1 commit intoDec 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
xiaoyongzhu
approved these changes
Dec 8, 2022
rakeshkashyap123
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix auto-tz casting bug. The original code was unable to handle primitive arrays, i.e. int[] and would throw an error Caused by: java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object; when encountering int[]. This specifically can cause an issue when trying to use auto-tz to convert from an array of floats to
type: { type: TENSOR tensorCategory: SPARSE dimensionType: [INT] valType: FLOAT }Changing it to use toArray resolves this issue.
How was this PR tested?
Added a new test case within integ test
Does this PR introduce any user-facing changes?
No