FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add retry when data loading fails by jaymo001 · Pull Request #930 · feathr-ai/feathr · GitHub

/ feathr Public

Add retry when data loading fails - #930

Merged
xiaoyongzhu merged 2 commits into
feathr-ai:mainfrom
jaymo001:dataLoadingRetry
Jan 27, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Add retry when data loading fails#930
xiaoyongzhu merged 2 commits into
feathr-ai:mainfrom
jaymo001:dataLoadingRetry

Conversation

jaymo001 commented Dec 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  1. When source data loading fails, wait and retry 2 times before fail the job. This could happen as the source is still being generated.
  2. Fix test setup to enable Mockito Mock usage

How was this PR tested?

Add unit test

Does this PR introduce any user-facing changes?

No

xiaoyongzhu commented Jan 21, 2023

Copy link
Copy Markdown
Member

Thanks @jaymo001 ! can you merge main back to your branch just to make sure CI is OK? there are quite some bug fixes on main

xiaoyongzhu added the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 21, 2023
bozhonghu approved these changes Jan 26, 2023
View reviewed changes

bozhonghu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

xiaoyongzhu merged commit dce3766 into feathr-ai:main Jan 27, 2023
jaymo001 added a commit to jaymo001/feathr that referenced this pull request Jan 30, 2023
Revert "Add retry when data loading fails (feathr-ai#930)"
7743614 
This reverts commit dce3766.
jaymo001 added a commit to jaymo001/feathr that referenced this pull request Jan 30, 2023
Revert "Add retry when data loading fails (feathr-ai#930)"
f38b01a 
This reverts commit dce3766.
xiaoyongzhu pushed a commit that referenced this pull request Jan 30, 2023
Revert "Add retry when data loading fails (#930)" (#1021)
a8dfa7b 
This reverts commit dce3766.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xiaoyongzhu xiaoyongzhu approved these changes
bozhonghu bozhonghu approved these changes
rakeshkashyap123 Awaiting requested review from rakeshkashyap123

Assignees

No one assigned

Labels

safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL