FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add pytest cases and check test coverage for sql-registry and purview… by enya-yx · Pull Request #937 · feathr-ai/feathr · GitHub

/ feathr Public

Add pytest cases and check test coverage for sql-registry and purview… - #937

Merged
enya-yx merged 18 commits into
feathr-ai:mainfrom
enya-yx:enya/registry-test-cov
Jan 10, 2023
ConversationCommits (18)ChecksFiles changed
Merged

Add pytest cases and check test coverage for sql-registry and purview…#937
enya-yx merged 18 commits into
feathr-ai:mainfrom
enya-yx:enya/registry-test-cov

Conversation

enya-yx commented Jan 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

…-registry

Description

  • Add test cases for sql-registry and purview-registry (server side)
  • Check test coverage and make sure it can get >=90%
  • Modify types annotations; eg. dict->Dict, list->List

How was this PR tested?

  • Check test coverage locally and they are 90% and 91% for sql and purview, respectively:

Does this PR introduce any user-facing changes?

  • [x ] No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

enya-yx added safe to test Tag to execute build pipeline for a PR from forked repo and removed safe to test Tag to execute build pipeline for a PR from forked repo labels Jan 3, 2023
enya-yx added the registry test Used to run test cases for registry label Jan 9, 2023
enya-yx requested review from Yuqing-cat and windoze January 10, 2023 07:57
Yuqing-cat previously approved these changes Jan 10, 2023
View reviewed changes
blrchen previously approved these changes Jan 10, 2023
View reviewed changes
enya-yx dismissed stale reviews from blrchen and Yuqing-cat via 5c39ff6 January 10, 2023 08:17
enya-yx merged commit c967f6d into feathr-ai:main Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

windoze windoze approved these changes
blrchen blrchen approved these changes
Yuqing-cat Yuqing-cat left review comments
xiaoyongzhu Awaiting requested review from xiaoyongzhu

Assignees

No one assigned

Labels

registry test Used to run test cases for registry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL