Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
paulirwin
marked this pull request as ready for review
October 22, 2025 18:15
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for .NET 8, 9, and 10 as additional target frameworks alongside the existing netstandard2.0 target. The key architectural change is that only the netstandard2.0 target will be signed with a strong name key, while the newer .NET targets remain unsigned.
- Adds net8.0, net9.0, and net10.0 as new target frameworks
- Conditionally applies strong-name signing only to netstandard2.0 target
- Updates project structure to use newer .slnx solution format and removes legacy Directory.Build.props files
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| src/F23.StringSimilarity/F23.StringSimilarity.csproj | Adds multiple target frameworks, conditional signing for netstandard2.0, and updates package versions |
| src/F23.StringSimilarity/Properties/AssemblyInfo.cs | Conditionally applies InternalsVisibleTo with public key only for signed assemblies |
| test/F23.StringSimilarity.Tests/F23.StringSimilarity.Tests.csproj | Adds conditional signing configuration for net481 target |
| benchmarks/F23.StringSimilarity.Benchmarks/F23.StringSimilarity.Benchmarks.csproj | Updates target framework to net10.0 and BenchmarkDotNet package version |
| F23.StringSimilarity.slnx | Adds new .slnx solution file format |
| F23.StringSimilarity.sln | Removes legacy .sln file |
| Directory.Build.props | Removes global signing configuration |
| src/Directory.Build.props | Removes source-level build props file |
| test/Directory.Build.props | Removes test-level build props file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
paulirwin
marked this pull request as draft
October 22, 2025 20:49
This reverts commit 5300e81.
paulirwin
marked this pull request as ready for review
October 22, 2025 20:50
jamesmblair
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the net8.0, net9.0, and net10.0 targets per the discussion/roadmap in #44. These new targets are not signed with a strong name key; only the netstandard2.0 target will be signed.
Fixes #50