Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR makes the GetProfile method in the ShingleBased base class public (changing from protected internal) and adds unit tests across all four derived classes (Cosine, Jaccard, QGram, SorensenDice) to ensure the method remains publicly accessible. The change addresses issue #21 and prevents future regressions. Additional refactoring in CosineTest.cs modernizes the code by removing unused dependencies and updating using statements to C# 8+ patterns.
Key Changes:
- Changed GetProfile visibility from protected internal to public in ShingleBased.cs
- Added GetProfile_IsPublic test method to four test classes to verify public API accessibility
- Modernized CosineTest.cs with updated using statement patterns and removed unused test infrastructure
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file| File | Description |
|---|---|
| src/F23.StringSimilarity/ShingleBased.cs | Made GetProfile method public and removed unused import |
| test/F23.StringSimilarity.Tests/CosineTest.cs | Added GetProfile_IsPublic test, removed unused imports/fields, modernized using statements, fixed primary constructor syntax |
| test/F23.StringSimilarity.Tests/JaccardTest.cs | Added GetProfile_IsPublic test |
| test/F23.StringSimilarity.Tests/QGramTest.cs | Added GetProfile_IsPublic test |
| test/F23.StringSimilarity.Tests/SorensenDiceTest.cs | Added GetProfile_IsPublic test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was a regression of #21, which now adds unit tests to ensure it doesn't regress in the future.
Fixes #21