Render objects by calling .toString() on them - #105
Open
joshski wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
refractalize
approved these changes
Jul 10, 2018
refractalize
force-pushed
the
render-objects-by-calling-tostring
branch
from
3e169fc to
b59f938
Compare
July 10, 2018 10:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to pass objects into hyperdom.html() and have hyperdom call .toString() on those objects.
Hyperdom calls JSON.stringify() when it doesn't know what else to do with an object. This might be reasonable behaviour for primitive objects, so this change preserves that behaviour, but calls .toString() on user-defined types that implement .toString()