FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add alt attribute to the gallery image by feimosi · Pull Request #120 · feimosi/baguetteBox.js · GitHub

/ baguetteBox.js Public

Add alt attribute to the gallery image - #120

Merged
feimosi merged 2 commits into
devfrom
feature/95-alt-attribute
Jul 23, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Add alt attribute to the gallery image#120
feimosi merged 2 commits into
devfrom
feature/95-alt-attribute

Conversation

feimosi commented Jul 23, 2016

Copy link
Copy Markdown
Owner

Resolves #96

feimosi commented Jul 23, 2016 •
edited
Loading

Copy link
Copy Markdown
Owner Author

@XhmikosR I'd appreciate if you could take a look and approve this PR :)
The solution is on the first commit.

feimosi force-pushed the feature/95-alt-attribute branch from 5b56626 to d7b6fd4 Compare July 23, 2016 11:14
XhmikosR reviewed Jul 23, 2016
View reviewed changes
Comment thread src/baguetteBox.js Outdated
var image = create('img');
var figcaption = create('figcaption');

// Prepare figure and figcaption elements

XhmikosR Jul 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"and figcaption elements" belongs to line 504 now I believe.

feimosi Jul 23, 2016

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Right, I've removed this unnecessary keyword

feimosi force-pushed the feature/95-alt-attribute branch from d7b6fd4 to c244460 Compare July 23, 2016 11:21

XhmikosR commented Jul 23, 2016

Copy link
Copy Markdown
Contributor

Looks good to me sans the refactoring patch which I assume you tested :)

feimosi commented Jul 23, 2016

Copy link
Copy Markdown
Owner Author

I wouldn't publish untested code :) Just wanted to make sure, we were thinking about the alt in the same way.

XhmikosR commented Jul 23, 2016

Copy link
Copy Markdown
Contributor

I know, better be safe than sorry :D

feimosi merged commit 031ad79 into dev Jul 23, 2016
feimosi deleted the feature/95-alt-attribute branch July 23, 2016 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL