FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

(feat) Add home/end key support by BartDelrue · Pull Request #179 · feimosi/baguetteBox.js · GitHub

/ baguetteBox.js Public

(feat) Add home/end key support - #179

Merged
feimosi merged 1 commit into
feimosi:devfrom
BartDelrue:feature/home-end-key
Sep 16, 2018
ConversationCommits (1)ChecksFiles changed
Merged

(feat) Add home/end key support#179
feimosi merged 1 commit into
feimosi:devfrom
BartDelrue:feature/home-end-key

Conversation

BartDelrue commented May 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pressing the home or end key takes you to the first or last image of the opened gallery.

Issue #180

Jeroen005 approved these changes Jul 2, 2018
View reviewed changes

Jeroen005 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looking good :)

BartDelrue mentioned this pull request Jul 2, 2018
Closed

meirege commented Jul 6, 2018

Copy link
Copy Markdown

We could really use this for an upcoming project at our firm. 👍

feimosi reviewed Jul 6, 2018
View reviewed changes
Comment thread src/baguetteBox.js

// Return false at the left end of the gallery
function showFirstImage(event) {
if (event) {

feimosi Jul 6, 2018

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we need the if? Is there a case where event is undefined?

BartDelrue Jul 6, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Currently no.
I included it in case you'd want to expose this function later on, cfr shownext etc.

BartDelrue Jul 23, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let me know if you want it gone ;)

meirege Sep 14, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could this be merged please? We could really use this feature...

feimosi Sep 16, 2018

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done, sorry for the delay

feimosi merged commit 8d038e3 into feimosi:dev Sep 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

feimosi feimosi left review comments
+2 more reviewers
meirege meirege approved these changes
Jeroen005 Jeroen005 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL