chore(deps): bump vite-plus to pkg-pr-new PR #1703 - #6
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request updates the pnpm-workspace.yaml file to use specific pkg.pr.new URLs for catalog and overrides, and configures release age exclusions. The reviewer noted that mixing PR numbers and commit hashes between the catalog and overrides can prevent package deduplication, and recommended aligning them to use the same commit hash specifier for deterministic builds.
Sorry, something went wrong.
| vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703 | ||
| vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1703 | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1703 |
There was a problem hiding this comment.
The catalog definitions use the PR number (@1703) while the overrides use the specific commit hash (@d0b407c85b560c2470395176c9f1c838b5ca8af8). Mixing these two different specifiers for the same packages can prevent the package manager from deduplicating them, leading to duplicate package installations in the lockfile and potential runtime or build issues.
It is highly recommended to align them to use the same specifier. Using the specific commit hash is preferred as it ensures deterministic and reproducible builds.
vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8
vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8
Sorry, something went wrong.
Summary
Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).
Test plan