Repository navigation
Fixed memory leak in the Websocket example - #157
Closed
Mis1eader-dev wants to merge 2 commits into
Closed
Mis1eader-dev wants to merge 2 commits into
Mis1eader-dev wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
It appears cleaning up dynamically allocated memory of individual WebsocketHandlers causes heap corruption, is memory cleanup handled by the library itself? I doubt that this is the case. There is an issue that is not visible in plain sight which has to do with memory deallocation. |
Sorry, something went wrong.
khoih-prog
added a commit
to khoih-prog/ESP32_HTTPS_Server
that referenced
this pull request
Sep 27, 2022
Merge some upstream PRs - Handling of errors - like unstable network - coming via SSL fhessel#89 - WIP: Prevent crash on WebSocket request to non-WebSocket node. fhessel#106 - Fix infinite loop when the buffer ends with \r fhessel#123 - Fixed memory leak in the Websocket example fhessel#157
This was referenced Sep 27, 2022
Closed
khoih-prog
added a commit
to khoih-prog/ESP32_HTTPS_Server
that referenced
this pull request
Sep 27, 2022
1. Merge some upstream PRs - Handling of errors - like unstable network - coming via SSL fhessel#89 - WIP: Prevent crash on WebSocket request to non-WebSocket node. fhessel#106 - Fix infinite loop when the buffer ends with \r fhessel#123 - Fixed memory leak in the Websocket example fhessel#157 2. Update examples and `README.md`
khoih-prog
added a commit
to khoih-prog/ESP32_HTTPS_Server
that referenced
this pull request
Sep 27, 2022
1. Merge some upstream PRs - Handling of errors - like unstable network - coming via SSL fhessel#89 - WIP: Prevent crash on WebSocket request to non-WebSocket node. fhessel#106 - Fix infinite loop when the buffer ends with \r fhessel#123 - Fixed memory leak in the Websocket example fhessel#157 2. Update examples and `README.md`
khoih-prog
added a commit
to khoih-prog/ESP32_HTTPS_Server
that referenced
this pull request
Sep 27, 2022
1. Merge some upstream PRs - Handling of errors - like unstable network - coming via SSL fhessel#89 - WIP: Prevent crash on WebSocket request to non-WebSocket node. fhessel#106 - Fix infinite loop when the buffer ends with \r fhessel#123 - Fixed memory leak in the Websocket example fhessel#157 2. Update examples and `README.md`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heap will fill up with memory leaks if the pointer of previous clients is nullified without freeing up their allocated memory.