Repository navigation
Fix infinite loop when a Websocket connection is lost - #58
fhessel merged 1 commit into
Conversation
Sorry, something went wrong.
…hout closing handshake.
|
Thank you for your contributions, I'll review them as soon as possible. The WebSocket implementation is still quite experimental, so there might be (or probably will be) more issues with it. |
Sorry, something went wrong.
fhessel
left a comment
There was a problem hiding this comment.
Could reproduce the problem (using a smartphone and killing the Browser was a good hint) and verify that your suggestion fixes it, so I'd say: Approved!
It might indeed not be an optimal solution to handle the client state in that place, as that is also done at the beginning of the loop() function (here to be precise), but the Websockets in general need some refactoring, so I think that's good for now.
Sorry, something went wrong.
When a client closes a Websocket connection without performing a clean closing hand-shake, the server enters an infinite loop. This happens when the client web-browser is killed. I noticed this behaviour when swiping out Chrome on Android.
The suggested change might not be the best fix possible, but it works.