[ONB-2513] Feat(v2): Add legal representative document upload - #129
Merged
tlarrain merged 1 commit intoJul 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Adds upload_legal_representative_document to the onboardings manager
(PUT .../legal_representatives/{id}/documents/{slot_key}) and the
OnboardingLegalRepresentative resource, mapped from the onboarding's
new legal_representatives array. Onboarding create now takes
legal_representatives as an array, replacing the singular
legal_representative object.
JoMarchant
approved these changes
Jul 7, 2026
JoMarchant
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the new v2 legal representative document upload endpoint:
Also models the legal_representatives array that the API now returns on the onboarding object: new OnboardingLegalRepresentative resource, with its documents mapped to OnboardingDocument.
Requirements
None.
Additional changes
The onboarding create integration test now sends legal_representatives as an array, matching the API's current request shape (the singular legal_representative object no longer exists).