FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Add .ConfigureAwait(false) to all async call by NiCoTinEz · Pull Request #109 · firebase/firebase-admin-dotnet · GitHub

/ firebase-admin-dotnet Public

fix: Add .ConfigureAwait(false) to all async call - #109

Merged
hiranya911 merged 1 commit into
firebase:masterfrom
NiCoTinEz:master
Aug 30, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix: Add .ConfigureAwait(false) to all async call#109
hiranya911 merged 1 commit into
firebase:masterfrom
NiCoTinEz:master

Conversation

NiCoTinEz commented Aug 30, 2019 •
edited by hiranya911
Loading

Copy link
Copy Markdown
Contributor

RELEASE NOTE: Fixed an issue that caused async API calls to deadlock in some environments.

Resolves #108

googlebot commented Aug 30, 2019

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

NiCoTinEz commented Aug 30, 2019

Copy link
Copy Markdown
Contributor Author

@googlebot I fixed it.

googlebot commented Aug 30, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

hiranya911 approved these changes Aug 30, 2019
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks @NiCoTinEz

hiranya911 changed the title Add .ConfigureAwait(false) to all async call fix: Add .ConfigureAwait(false) to all async call Aug 30, 2019
hiranya911 self-assigned this Aug 30, 2019
hiranya911 merged commit e9c8cad into firebase:master Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
hiranya911 hiranya911 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

hiranya911

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Got Deadlock on FirebaseMessaging.SendAsync(msg).ConfigureAwait(false).GetAwaiter().GetResult()

3 participants

Back | FazBrowse Home | New Git URL