feat (fcm): Add additional Android Notification Parameters - #317
Merged
lahirumaramba merged 5 commits intoMar 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lahirumaramba
force-pushed
the
lm-fcm-notif
branch
from
ab58123 to
32821c0
Compare
March 4, 2022 18:51
lahirumaramba
marked this pull request as ready for review
March 4, 2022 19:36
This was referenced Mar 4, 2022
egilmorez
reviewed
Mar 4, 2022
egilmorez
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Picked out a few style things to look at, thanks!
Sorry, something went wrong.
Comment thread
FirebaseAdmin/FirebaseAdmin/Messaging/AndroidNotification.cs
Outdated
Comment thread
FirebaseAdmin/FirebaseAdmin/Messaging/LightSettings.cs
Outdated
Comment thread
FirebaseAdmin/FirebaseAdmin/Messaging/LightSettings.cs
Outdated
chong-shao
approved these changes
Mar 9, 2022
chong-shao
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM. Probably we can wait until the naming of visibility and priority to be finalized before submitting this?
Sorry, something went wrong.
egilmorez
approved these changes
Mar 14, 2022
egilmorez
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks Lahiru!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #153
go/admin-fcm-notificaiton-addendum
RELEASE NOTE: Added a series of new parameters to the AndroidNotification class that allow further customization of notifications that target Android devices.