FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feature: multicast messaging by kentcb · Pull Request #36 · firebase/firebase-admin-dotnet · GitHub

/ firebase-admin-dotnet Public

feature: multicast messaging - #36

Merged
hiranya911 merged 7 commits into
firebase:masterfrom
kentcb:multicastmessaging
Mar 26, 2019
ConversationCommits (7)ChecksFiles changed
Merged

feature: multicast messaging#36
hiranya911 merged 7 commits into
firebase:masterfrom
kentcb:multicastmessaging

Conversation

kentcb commented Mar 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add support for multicast/send-all messaging.

kentcb mentioned this pull request Mar 21, 2019
Closed
kentcb force-pushed the multicastmessaging branch 2 times, most recently from a855e2b to 81a4a5e Compare March 22, 2019 00:30
kentcb force-pushed the multicastmessaging branch from 81a4a5e to ec7d7d4 Compare March 22, 2019 00:36
kentcb marked this pull request as ready for review March 22, 2019 00:39

kentcb commented Mar 22, 2019

Copy link
Copy Markdown
Contributor Author

@hiranya911 Ready for review.

hiranya911 commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

Thank you @kentcb. Love what you've done here. I will take a closer look tomorrow morning. If all goes well I think we can release this next week (this API was already proposed and approved at the same time I worked on the Node and Java implementations).

hiranya911 self-assigned this Mar 22, 2019
hiranya911 suggested changes Mar 22, 2019
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks again @kentcb for putting this together. Really appreciate you putting in the effort to provide a PR complete with unit and integration tests. I've pointed out a few things that should be changed. I think most of them are minor nits. The areas that need most work are:

  1. Validating message list in FirebaseMessagingClient
  2. Changing how MulticastMessage is unit tested

Please let me know if you have any questions.

Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/BatchItemResponse.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/BatchItemResponse.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/BatchResponse.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/BatchResponse.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/BatchResponse.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/MulticastMessage.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Extensions.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin.Tests/Messaging/MulticastMessageTest.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin.Tests/Messaging/MulticastMessageTest.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin.Tests/Messaging/FirebaseMessagingClientTest.cs

kentcb commented Mar 25, 2019

Copy link
Copy Markdown
Contributor Author

@hiranya911 Thanks very much for the review. I've pushed fixes based on your comments.

hiranya911 suggested changes Mar 25, 2019
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks again @kentcb. I think we're almost there. Just a few more changes to make. My two big feedback points are on the public API surface:

  1. What is currently called SendResponse should be called BatchResponse.
  2. What is currently called SendItemResponse should be called SendResponse.

Sorry, if it wasn't clear from my earlier comments.

Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/SendResponse.cs
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/SendItemResponse.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/SendResponse.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/MulticastMessage.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs Outdated
Comment thread FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessaging.cs Outdated

kentcb commented Mar 25, 2019

Copy link
Copy Markdown
Contributor Author

@hiranya911 Ah, my bad. OK, I've fixed that as well as the other items you pointed out.

hiranya911 approved these changes Mar 25, 2019
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks. LGTM 👍

I'll try to publish a release in a couple of days.

hiranya911 merged commit ae0d725 into firebase:master Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
hiranya911 hiranya911 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL