fix: use .equals() instead of == for strings - #1065
Merged
jonathanedey merged 1 commit intoJan 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jonathanedey
self-requested a review
January 27, 2025 21:49
jonathanedey
approved these changes
Jan 28, 2025
jonathanedey
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, thanks @yanikapitanov!
As for testing we will add a follow up PR with updated tests.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix for string comparison.
From what I could see these changes are already covered by unit tests and I was not sure how to add new ones to test this specific scenario.