feat(fcm): Support proxy field in FCM AndroidNotification - #1084
Merged
jonathanedey merged 3 commits intoMar 21, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chong-shao
approved these changes
Mar 14, 2025
Comment thread
src/main/java/com/google/firebase/messaging/AndroidNotification.java
Outdated
Comment on lines
+212
to
+213
| public enum Proxy { | ||
| PROXY_UNSPECIFIED, |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Let's remove PROXY_UNSPECIFIED and have the absence of the field be enough to show it's not specified.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
PROXY_UNSPECIFIED is removed.
Thanks for the feedback.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you @vitvvv1 for your contribution!
Looks good, added one more comment. Could you also resolve the lint error blocking tests.
Sorry, something went wrong.
Comment thread
src/main/java/com/google/firebase/messaging/AndroidNotification.java
Outdated
jonathanedey
requested review from
OrlandriaH-G
and removed request for
egilmorez
March 18, 2025 14:55
OrlandriaH-G
approved these changes
Mar 19, 2025
…n.java fix comment AndroidNotification.setProxy Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added proxy field that described on page:
https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#androidnotification