FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add given httpTransport in GooglePublicKeysManager by xbauquet · Pull Request #151 · firebase/firebase-admin-java · GitHub

Add given httpTransport in GooglePublicKeysManager - #151

Merged
hiranya911 merged 1 commit into
firebase:masterfrom
xbauquet:master
Mar 9, 2018
Merged

Add given httpTransport in GooglePublicKeysManager#151
hiranya911 merged 1 commit into
firebase:masterfrom
xbauquet:master

Conversation

xbauquet commented Mar 9, 2018

Copy link
Copy Markdown
Contributor

Construct the default GooglePublicKeysManager with the custom
httpTransport. This avoid error due to proxy.
Fixes #150

Construct the default GooglePublicKeysManager with the custom
httpTransport. This avoid error due to proxy.
Fixes firebase#150

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

xbauquet commented Mar 9, 2018

Copy link
Copy Markdown
Contributor Author

I signed it!

Copy link
Copy Markdown

CLAs look good, thanks!

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

Thanks @xbauquet for the contribution.

hiranya911 self-assigned this Mar 9, 2018
hiranya911 merged commit aca5fcc into firebase:master Mar 9, 2018

quackes commented Apr 12, 2018

Copy link
Copy Markdown

Hi,
when will this be released?

Copy link
Copy Markdown
Contributor

I'll try to find some time next week to stage a release.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL