Upgraded google-cloud-firestore to the latest version (0.61.0-beta) … - #205
Closed
RohanTalip wants to merge 1 commit into
Closed
Upgraded google-cloud-firestore to the latest version (0.61.0-beta) …#205RohanTalip wants to merge 1 commit into
RohanTalip wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…nd added a FirebaseOptions#setFireStoreTimestampsInSnapshotsEnabled(boolean) method. The FirestoreOptions#setTimestampsInSnapshotsEnabled(boolean) method is then called in the FirestoreClient constructor with the value passed to the FirebaseOptions#setFireStoreTimestampsInSnapshotsEnabled(boolean) method. This allows for firebase-admin-java users to adapt to the Timestamps being returned in DocumentSnapshots as added in googleapis/google-cloud-java#3317 com.google.api:gax was added as a dependency to the pom.xml file as there were "java.lang.NoClassDefFoundError: com/google/api/gax/rpc/ClientStream" errors when running "mvn test" without this dependency. A couple of tests were also added to the FirestoreClientTest class.
Copy link
Copy Markdown
Contributor
|
There is already some work to support this. Plan is to support passing an entire FirestoreOptions object into FirebaseOptions. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Great! I see your recent commits on #203 . I wasn't sure if exposing the whole FirestoreOptions object was going to be accepted in the code review, so I tried just exposing only what I needed. Thanks for working on this @hiranya911 ! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and added a FirebaseOptions#setFireStoreTimestampsInSnapshotsEnabled(boolean) method.
The FirestoreOptions#setTimestampsInSnapshotsEnabled(boolean) method is then called in the FirestoreClient constructor with the value passed to the FirebaseOptions#setFireStoreTimestampsInSnapshotsEnabled(boolean) method.
This allows for firebase-admin-java users to adapt to the Timestamps being returned in DocumentSnapshots as added in googleapis/google-cloud-java#3317
com.google.api:gax was added as a dependency to the pom.xml file as there were "java.lang.NoClassDefFoundError: com/google/api/gax/rpc/ClientStream" errors when running "mvn test" without this dependency.
A couple of tests were also added to the FirestoreClientTest class.
See also issue #204.