FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add emulator-based integration tests. by yuchenshi · Pull Request #1155 · firebase/firebase-admin-node · GitHub

/ firebase-admin-node Public

Add emulator-based integration tests. - #1155

Merged
yuchenshi merged 9 commits into
masterfrom
ys/integration-emulator
Mar 23, 2021
ConversationCommits (9)ChecksFiles changed
Merged

Add emulator-based integration tests.#1155
yuchenshi merged 9 commits into
masterfrom
ys/integration-emulator

Conversation

yuchenshi commented Feb 4, 2021

Copy link
Copy Markdown
Member

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

This is a follow up to #1148 and enables emulator-based integration tests.

Testing

This covers Firestore and most of Auth and database.

API Changes

N/A

yuchenshi force-pushed the ys/integration-emulator branch from c653f95 to 9aecf74 Compare February 4, 2021 19:06
yuchenshi marked this pull request as ready for review February 5, 2021 21:23
yuchenshi requested a review from hiranya911 February 5, 2021 21:23
yuchenshi mentioned this pull request Feb 5, 2021
Merged
hiranya911 suggested changes Feb 5, 2021
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @yuchenshi. Really like how this is turning out. My main point of feedback is about managing the emulator-based integration tests entirely within the Actions workflow, rather than in package.json. That's consistent with how we did this in Python, and keeps the package.json file clean of changes.

Comment thread .github/workflows/ci.yml Outdated
Comment thread package.json Outdated
Comment thread .github/workflows/ci.yml
hiranya911 assigned yuchenshi and unassigned hiranya911 Feb 5, 2021
yuchenshi requested a review from hiranya911 February 10, 2021 17:23
yuchenshi assigned hiranya911 and unassigned yuchenshi Feb 10, 2021

yuchenshi commented Feb 10, 2021

Copy link
Copy Markdown
Member Author

Sorry I was OOO and I've now reverted package.json changes as requested.

hiranya911 approved these changes Feb 11, 2021
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @yuchenshi. LGTM with a couple of nits. Feel free to merge once the comments are addressed.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
hiranya911 assigned yuchenshi and unassigned hiranya911 Feb 11, 2021

yuchenshi commented Feb 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

I see one flaky test here and I'll investigate later. Don't merge for now please! https://github.com/firebase/firebase-admin-node/pull/1155/checks?check_run_id=1881208101#step:7:197

It's unclear if it's flaky due to some issue in Auth Emulator or maybe the test itself has race conditions that got worse since Auth Emulator is much faster than prod.

hiranya911 mentioned this pull request Mar 4, 2021
Merged
2 tasks
yuchenshi mentioned this pull request Mar 9, 2021
Merged
yuchenshi merged commit 97d3823 into master Mar 23, 2021
yuchenshi deleted the ys/integration-emulator branch March 23, 2021 00:48

yuchenshi commented Mar 23, 2021

Copy link
Copy Markdown
Member Author

Merging now since the tests now pass. Feel free to skip that one test for emulators if this comes up again. Let's at least have coverage for the other tests.

This was referenced Jun 20, 2024
Open
Open
Open
Open
davidhin mentioned this pull request Jul 6, 2024
Open
This was referenced Jul 17, 2024
Open
Open
This was referenced Jul 27, 2024
Open
Open
Open
Open
This was referenced Aug 10, 2024
Open
Open
This was referenced Aug 17, 2024
Open
Open
Open
Open
Open
This was referenced Aug 28, 2024
Open
Open
This was referenced Sep 5, 2024
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
This was referenced Oct 26, 2024
Open
Open
davidhin mentioned this pull request Nov 9, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
hiranya911 hiranya911 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

yuchenshi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL