FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Export error classes by IchordeDionysos · Pull Request #2151 · firebase/firebase-admin-node · GitHub

fix: Export error classes - #2151

Merged
lahirumaramba merged 4 commits into
firebase:masterfrom
IchordeDionysos:patch-1
May 8, 2024
Merged

fix: Export error classes#2151
lahirumaramba merged 4 commits into
firebase:masterfrom
IchordeDionysos:patch-1

Conversation

IchordeDionysos commented Apr 17, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Discussion

Expose the FirebaseError classes to enable code like this:

catch (e) {
  if (e instanceof FirebaseError) {
    if (e.code === 'auth/' + AuthClientErrorCode.USER_NOT_FOUND.code) {
      throw new UserNotFoundException({email});
    }
  }
  throw e;
}

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

Copy link
Copy Markdown

Would love to see this added, it doesn't appear there's another way to easily access the error types from this package?

Copy link
Copy Markdown

I agree this is needed and follows the standard JS pattern for checking for a particular error. Error handling is important to good quality code and this library needs to support that also.

@IchordeDionysos this has got out of data with the base branch may need an update

lahirumaramba changed the title Expose error classes fix: Export error classes May 8, 2024
lahirumaramba self-assigned this May 8, 2024

lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you @IchordeDionysos ! LGTM!

lahirumaramba mentioned this pull request May 8, 2024
lahirumaramba merged commit bde4308 into firebase:master May 8, 2024
IchordeDionysos deleted the patch-1 branch June 11, 2024 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL