FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(app-check): support `httpAgent` in `JwksFetcher` by hermanho · Pull Request #2689 · firebase/firebase-admin-node · GitHub

/ firebase-admin-node Public

fix(app-check): support httpAgent in JwksFetcher - #2689

Merged
lahirumaramba merged 2 commits into
firebase:masterfrom
hermanho:fix/jwks-http-proxy
Sep 4, 2024
ConversationCommits (2)ChecksFiles changed
Merged

fix(app-check): support httpAgent in JwksFetcher#2689
lahirumaramba merged 2 commits into
firebase:masterfrom
hermanho:fix/jwks-http-proxy

Conversation

hermanho commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

Fix: support httpAgent in JwksFetcher #2684

hermanho force-pushed the fix/jwks-http-proxy branch 4 times, most recently from f94cf42 to ae80c99 Compare August 28, 2024 21:24
hermanho force-pushed the fix/jwks-http-proxy branch from ae80c99 to 6b55c00 Compare August 28, 2024 21:25
hermanho marked this pull request as ready for review August 28, 2024 21:28
lahirumaramba changed the title fix: support httpAgent in JwksFetcher fix: support httpAgent in JwksFetcher Aug 29, 2024
lahirumaramba changed the title fix: support httpAgent in JwksFetcher fix(app-check): support httpAgent in JwksFetcher Aug 29, 2024
lahirumaramba approved these changes Aug 29, 2024
View reviewed changes

lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you @hermanho for your contribution! LGTM!

hermanho commented Aug 29, 2024

Copy link
Copy Markdown
Contributor Author

For the CI build failed in 22.x, it is related to a bug in nodejs v22.7.0.
protobufjs/protobuf.js#2025
nodejs/node#54518

It should be fixed in v22.8.0. I tested with v22.6.0 in local machine and no problem in emulator-based integration tests.

lahirumaramba commented Aug 30, 2024

Copy link
Copy Markdown
Member

For the CI build failed in 22.x, it is related to a bug in nodejs v22.7.0. protobufjs/protobuf.js#2025 nodejs/node#54518

It should be fixed in v22.8.0. I tested with v22.6.0 in local machine and no problem in emulator-based integration tests.

Yep! Looks like they plan to release 22.8.0 next week. Let's wait and rerun the tests next week. If the Node release is delayed I can update the workflows to pin to 22.6.0

lahirumaramba mentioned this pull request Aug 30, 2024
Closed
lahirumaramba merged commit 2fb4a27 into firebase:master Sep 4, 2024
kenn7575 mentioned this pull request Oct 4, 2024
Merged
rasheedadultedpro mentioned this pull request Oct 4, 2024
Open
TartejBrothers mentioned this pull request Oct 4, 2024
Merged
This was referenced Oct 4, 2024
Open
Open
Open
kenn7575 mentioned this pull request Oct 27, 2024
Closed
This was referenced Oct 30, 2024
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lahirumaramba lahirumaramba approved these changes

Assignees

No one assigned

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL