FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(fcm): Support `apns.live_activity_token` field in FCM `ApnsConfig` by janodetzel · Pull Request #2891 · firebase/firebase-admin-node · GitHub

/ firebase-admin-node Public

feat(fcm): Support apns.live_activity_token field in FCM ApnsConfig - #2891

Merged
jonathanedey merged 3 commits into
firebase:masterfrom
janodetzel:master
Jun 3, 2025
ConversationCommits (3)ChecksFiles changed
Merged

feat(fcm): Support apns.live_activity_token field in FCM ApnsConfig#2891
jonathanedey merged 3 commits into
firebase:masterfrom
janodetzel:master

Conversation

janodetzel commented Apr 6, 2025

Copy link
Copy Markdown
Contributor
  • feat(fcm): Support live_activity_token field on ApnsConfig
  • added validation
  • update documentation

Fixes #2875

janodetzel mentioned this pull request Apr 6, 2025
Closed
allenkaplan reviewed Apr 25, 2025
View reviewed changes
Comment thread test/unit/messaging/messaging.spec.ts
});
});

const invalidApnsLiveActivityTokens: any[] = [null, NaN, 0, 1, true, false]

allenkaplan Apr 25, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

perhaps we should add a test for valid payload?

janodetzel May 5, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure thing. I added the tests with valid payloads for the live activity start | update | end events

lahirumaramba self-assigned this May 12, 2025
lahirumaramba previously requested changes May 12, 2025
View reviewed changes

lahirumaramba left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for your contribution! Could you change the new property to lowerCamelCase formatting?
Can you also run npm run api-extractor:local? That would update the api docs and should fix the CI errors. Thanks!

Comment thread src/messaging/messaging-api.ts Outdated
feat(fcm): Support apns.live_activity_token field in FCM ApnsConfig
6b5079e 
* feat(fcm): Support `live_activity_token` field on `ApnsConfig`
* added validation
* update documentation
janodetzel force-pushed the master branch 2 times, most recently from 756c68d to 1d032bd Compare May 30, 2025 20:37
janodetzel requested a review from lahirumaramba May 30, 2025 20:51
jonathanedey removed the request for review from lahirumaramba June 3, 2025 13:45
jonathanedey dismissed lahirumaramba’s stale review June 3, 2025 19:32

Review requested changes were made and error addressed. Removing to unblock.

jonathanedey merged commit d762464 into firebase:master Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jonathanedey jonathanedey approved these changes
lahirumaramba lahirumaramba left review comments
+3 more reviewers
allenkaplan allenkaplan left review comments
chong-shao chong-shao approved these changes
OrlandriaH-G OrlandriaH-G approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jonathanedey

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing fields in apns type definition for FCM live activities

6 participants

Back | FazBrowse Home | New Git URL