FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Add transporterOptions when serviceAccountPathOrObject parameter is a object in admin.credential.cert() by FTD-YI · Pull Request #2961 · firebase/firebase-admin-node · GitHub

/ firebase-admin-node Public

fix: Add transporterOptions when serviceAccountPathOrObject parameter is a object in admin.credential.cert() - #2961

Open
FTD-YI wants to merge 6 commits into
firebase:mainfrom
FTD-YI:master
ConversationCommits (6)ChecksFiles changed
Open

fix: Add transporterOptions when serviceAccountPathOrObject parameter is a object in admin.credential.cert()#2961
FTD-YI wants to merge 6 commits into
firebase:mainfrom
FTD-YI:master

Conversation

FTD-YI commented Aug 25, 2025

Copy link
Copy Markdown

Discussion

To fix the issue: #2960.

Testing

All tests passed.

API Changes

No Changes.

google-cla Bot commented Aug 25, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

FTD-YI mentioned this pull request Aug 25, 2025
Open

FTD-YI commented Aug 25, 2025

Copy link
Copy Markdown
Author

Please review.
@jonathanedey @lahirumaramba @DellaBitta

lahirumaramba self-requested a review August 26, 2025 21:01
lahirumaramba self-assigned this Aug 26, 2025
lahirumaramba approved these changes Nov 4, 2025
View reviewed changes

lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for the contribution! LGTM!

edward-s commented Nov 28, 2025

Copy link
Copy Markdown

We encountered this issue, can this be merged and be included in the next release?

FTD-YI commented May 12, 2026

Copy link
Copy Markdown
Author

Hi @lahirumaramba, can we get this PR merged? thx

FTD-YI requested a review from lahirumaramba July 28, 2026 13:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lahirumaramba Awaiting requested review from lahirumaramba

Assignees

lahirumaramba

Labels

api: core release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL