feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform by bojeil-google · Pull Request #804 · firebase/firebase-admin-node · GitHub

Defines multi-factor auth administrative APIs for Google Cloud Identity Platform.

RELEASE NOTE: Added multi-factor authentication support with SMS for Google Cloud Identity Platform. Existing APIs like createUser() and updateUser() now supports configuring multi-factor authentication settings for user accounts.

Updates UserRecord to parse multi-factor related information from the GetAccountInfo server response. First step in supporting multi-factor authentication with SMS as a second factor.

* Adds ability to import users with phone second factors. * Addresses review comments.

* Adds multi-factor support for updateUser. This will allow the ability to update the list of second factors on an existing user record.

* Extends createUser to support multi-factor user creation. Note that only phoneNumber and displayName are allowed to be passed in this operation. Adds relevant unit and integration tests. This capability is only available in staging.

…gs. (#752) * Adds backend multi-factor auth related errors and their client mappings.

…on. (#766) * Defines the d.ts multi-factor related comments for reference generation. * Adds missing multi-factor related claims to the `DecodedIdToken` interface.

I didn't do a full line-by-line review, since it's already reviewed code (please let me know if I should pay particular attention to any specific things). I did point out a few things about naming, and the way some fields are exposed in the public API. And I also found one bad merge in the FCM code.

Thanks for making the changes. LGTM with one comment.

Now that you've changed the other instances in this file, it makes sense to change this to MultiFactorInfo too. I think that's safer for users. Otherwise code like the following snippet will break in a future release:

const user = await admin.auth().getUser(uid);
if (user.multiFactor) {
  const factor = user.multiFactor.enrolledFactors[0];
  console.log(factor.phoneNumber); // this line will break when we change the type in a future release
}

Done.

* Custom Action for sending Tweets (#784) * Experimental custom Action for sending Tweets * Added license headers * Added README file * Updated package descriptions * Improve customClaims Typing (#768) * chore: Experimental release flow based on Actions (#780) * chore: Experimental release flow based on Actions * Added tarball verification step; Simplified CI trigger * Splitting staging and publish phases into separate jobs * Fleshed out the full workflow * Trigger RC build * chore: Migrated to ESlint (#790) * chore: Migrated to ESlint * Added licesne header * Enabling additional ESLint checks (#794) * chore: Enabling more ESLint checks and fixing errors (#797) * Fix compilation error in integration tests (#798) Introduced by #790 * Build integration tests during CI (and release) (#800) Note that this won't actually run them. Additionally, the *unit* tests are also built, impying that we're building them twice (once during this step, and possibly again when running the unit tests.) * Fix revokeRefreshTokens to round consistently with the other platforms. (#801) This also makes it consistent with the comments a few lines above, as well as the integration test. * feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform (#804) Defines multi-factor auth administrative APIs for Google Cloud Identity Platform. * Defines new MFA types in toc.yaml. (#807) * Removes special char from index.d.ts. (#808) This is causing errors in the reference generation process. * Defines MultiFactor{Create|Update}Settings interfaces. (#809) * Defines MultiFactor{Create|Update}Settings interfaces. * chore: Adding a .npmrc file to the root of the repo (#810) * chore: Adding a .npmrc file to the root of the repo * Removing the root-level .npmrc file * [chore] Release 8.10.0 (#811) * [chore] Release 8.10.0 (take 2) (#812) * Bump acorn from 6.1.1 to 6.4.1 (#815) Bumps [acorn](https://github.com/acornjs/acorn) from 6.1.1 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.1.1...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixing Android notification options descriptions (#820) * Fixing doc bug that conflated sound and tag options for Android notifications. * Removing duplicate documentation for tag. * Adding tag details in the right place this time, hopefully. * chore: Splitting the index.d.ts file into smaller files (#751) * Splitting the index.d.ts file into smaller files * Database return type fixed * chore: Cleaning up package verification scripts (#822) * chore: Cleaning up package verification scripts * Added package metadata to test package.json file * fix(auth): Fixing UserImportRecord typings declaration (#835) * fix(auth): Fixing UserImportRecord typings declaration * Fixing more integration test compilation errors * Trigger CI * Removed redundant line * Bump minimist from 1.2.0 to 1.2.3 (#839) Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.3. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remerge conflict Co-authored-by: Hiranya Jayathilaka <hiranya911@gmail.com> Co-authored-by: William Sedlacek <wsedlacekc@gmail.com> Co-authored-by: rsgowman <rgowman@google.com> Co-authored-by: bojeil-google <bojeil-google@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: egilmorez <egilmore@google.com>

* Firebase ML Node.js SDK Structure (#778) * Firebase ML Node.js SDK Structure * added tests * Added GetModel functionality and tests (#781) * Added GetModel functionality and tests * Added DeleteModel functionality and tests (#782) * Added DeleteModel functionality and tests * Added CreateModel functionality and tests (#788) * Added CreateModel functionality and tests * Added UpdateModel, publishModel,and unpublishModel functionality + tests (#791) * Added UpdateModel, publishModel,and unpublishModel functionality plus tests * Added ListModels functionality for Firebase ML (#795) * Added ListModels functionality for Firebase ML * Firebase ML changed endpoint (#813) * Add ML APIs to docgen toc (#847) * Docstring fixes and additions (#848) * Docstring fixes and additions * A few edits * Ml merge (#851) * Custom Action for sending Tweets (#784) * Experimental custom Action for sending Tweets * Added license headers * Added README file * Updated package descriptions * Improve customClaims Typing (#768) * chore: Experimental release flow based on Actions (#780) * chore: Experimental release flow based on Actions * Added tarball verification step; Simplified CI trigger * Splitting staging and publish phases into separate jobs * Fleshed out the full workflow * Trigger RC build * chore: Migrated to ESlint (#790) * chore: Migrated to ESlint * Added licesne header * Enabling additional ESLint checks (#794) * chore: Enabling more ESLint checks and fixing errors (#797) * Fix compilation error in integration tests (#798) Introduced by #790 * Build integration tests during CI (and release) (#800) Note that this won't actually run them. Additionally, the *unit* tests are also built, impying that we're building them twice (once during this step, and possibly again when running the unit tests.) * Fix revokeRefreshTokens to round consistently with the other platforms. (#801) This also makes it consistent with the comments a few lines above, as well as the integration test. * feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform (#804) Defines multi-factor auth administrative APIs for Google Cloud Identity Platform. * Defines new MFA types in toc.yaml. (#807) * Removes special char from index.d.ts. (#808) This is causing errors in the reference generation process. * Defines MultiFactor{Create|Update}Settings interfaces. (#809) * Defines MultiFactor{Create|Update}Settings interfaces. * chore: Adding a .npmrc file to the root of the repo (#810) * chore: Adding a .npmrc file to the root of the repo * Removing the root-level .npmrc file * [chore] Release 8.10.0 (#811) * [chore] Release 8.10.0 (take 2) (#812) * Bump acorn from 6.1.1 to 6.4.1 (#815) Bumps [acorn](https://github.com/acornjs/acorn) from 6.1.1 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.1.1...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixing Android notification options descriptions (#820) * Fixing doc bug that conflated sound and tag options for Android notifications. * Removing duplicate documentation for tag. * Adding tag details in the right place this time, hopefully. * chore: Splitting the index.d.ts file into smaller files (#751) * Splitting the index.d.ts file into smaller files * Database return type fixed * chore: Cleaning up package verification scripts (#822) * chore: Cleaning up package verification scripts * Added package metadata to test package.json file * fix(auth): Fixing UserImportRecord typings declaration (#835) * fix(auth): Fixing UserImportRecord typings declaration * Fixing more integration test compilation errors * Trigger CI * Removed redundant line * Bump minimist from 1.2.0 to 1.2.3 (#839) Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.3. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remerge conflict Co-authored-by: Hiranya Jayathilaka <hiranya911@gmail.com> Co-authored-by: William Sedlacek <wsedlacekc@gmail.com> Co-authored-by: rsgowman <rgowman@google.com> Co-authored-by: bojeil-google <bojeil-google@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: egilmorez <egilmore@google.com> * Added Firebase ML API requirements to Contributing doc (#853) Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com> Co-authored-by: Hiranya Jayathilaka <hiranya911@gmail.com> Co-authored-by: William Sedlacek <wsedlacekc@gmail.com> Co-authored-by: rsgowman <rgowman@google.com> Co-authored-by: bojeil-google <bojeil-google@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: egilmorez <egilmore@google.com>

bojeil-google and others added 9 commits October 23, 2019 19:21

Populates UserRecord with multi-factor related info (#681 )

fa7f2ec

Updates UserRecord to parse multi-factor related information from the GetAccountInfo server response. First step in supporting multi-factor authentication with SMS as a second factor.

Adds ability to import users with phone second factors. (#699 )

5ac091b

* Adds ability to import users with phone second factors. * Addresses review comments.

Adds multi-factor support for updateUser (#706 )

70b7da9

* Adds multi-factor support for updateUser. This will allow the ability to update the list of second factors on an existing user record.

Merged with master (#727 )

34e2ab9

Adds backend multi-factor auth related errors and their client mappin…

72987f3

…gs. (#752) * Adds backend multi-factor auth related errors and their client mappings.

Defines the d.ts multi-factor related comments for reference generati…

f7b445d

…on. (#766) * Defines the d.ts multi-factor related comments for reference generation. * Adds missing multi-factor related claims to the `DecodedIdToken` interface.

Merge branch 'master' into auth-mfa-temp

372a0d4

Added comment.

bc41612

bojeil-google requested a review from hiranya911 March 7, 2020 02:53

bojeil-google assigned hiranya911 Mar 7, 2020

hiranya911 suggested changes Mar 8, 2020

View reviewed changes

bojeil-google added 2 commits March 7, 2020 23:16

Addresses review comments.

c88ec89

Fixes test failures.

16c9f46

hiranya911 approved these changes Mar 9, 2020

View reviewed changes

hiranya911 assigned bojeil-google and unassigned hiranya911 Mar 9, 2020

hiranya911 added release-note release:stage Stage a release candidate labels Mar 9, 2020

bojeil-google added 2 commits March 9, 2020 11:40

Address review comment.

b747c8c

Fixes broken test.

ac785a2

bojeil-google merged commit 0a6c956 into master Mar 9, 2020

bojeil-google deleted the auth-mfa-temp branch March 10, 2020 22:30

This was referenced Apr 4, 2020

[Snyk] Upgrade firebase-admin from 8.9.2 to 8.10.0 aravindvnair99/Phishing#29

Closed

[Snyk] Upgrade firebase-admin from 8.9.2 to 8.10.0 aravindvnair99/ClassesAtAmrita#31

Closed

snyk-bot mentioned this pull request Apr 18, 2020

[Snyk] Upgrade firebase-admin from 8.9.2 to 8.10.0 SamReeve96/Acetate-Dissertation-Prototype-#89

Merged

This was referenced Apr 21, 2020

[Snyk] Upgrade firebase-admin from 8.9.2 to 8.10.0 SamReeve96/Acetate-Dissertation-Prototype-#92

Open

[Snyk] Upgrade firebase-admin from 8.3.0 to 8.10.0 sniperadmin/vue-commerce#3

Open

This was referenced Apr 22, 2020

[Snyk] Upgrade firebase-admin from 8.9.2 to 8.10.0 SafeSafe-app/opentrace-cloud-functions#4

Merged

[Snyk] Upgrade firebase-admin from 8.10.0 to 8.11.0 tuan231195/sportywide-news#17

Closed

+                     * List of second factors enrolled with the current user.
+                     * Currently only phone second factors are supported.
+                     */
+                    enrolledFactors: PhoneMultiFactorInfo[];

feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform by bojeil-google · Pull Request #804 · firebase/firebase-admin-node · GitHub

Uh oh!

feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform - #804

feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform#804
bojeil-google merged 13 commits into
masterfrom
auth-mfa-temp

bojeil-google commented Mar 7, 2020 •
edited by hiranya911
Loading

Uh oh!

Uh oh!

hiranya911 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hiranya911 left a comment

Uh oh!

hiranya911 Mar 9, 2020

Uh oh!

bojeil-google Mar 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform by bojeil-google · Pull Request #804 · firebase/firebase-admin-node · GitHub

Uh oh!

feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform - #804

feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform#804bojeil-google merged 13 commits intomasterfirebase/firebase-admin-node:masterfrom auth-mfa-tempfirebase/firebase-admin-node:auth-mfa-tempCopy head branch name to clipboard

Conversation

bojeil-google commented Mar 7, 2020 • edited by hiranya911 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hiranya911 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hiranya911 left a comment

Choose a reason for hiding this comment

Uh oh!

hiranya911 Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

bojeil-google Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(auth): Multi-factor Auth support with SMS for Google Cloud Identity Platform#804
bojeil-google merged 13 commits into
masterfrom
auth-mfa-temp

bojeil-google commented Mar 7, 2020 •
edited by hiranya911
Loading