FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add snippets to the admin repo by samtstern · Pull Request #130 · firebase/firebase-admin-python · GitHub

/ firebase-admin-python Public

Add snippets to the admin repo - #130

Merged
samtstern merged 6 commits into
masterfrom
snippets
Feb 20, 2018
ConversationCommits (6)ChecksFiles changed
Merged

Add snippets to the admin repo#130
samtstern merged 6 commits into
masterfrom
snippets

Conversation

samtstern commented Feb 16, 2018

Copy link
Copy Markdown
Contributor

They are linted by lint.sh, not sure if that fails below a certain score?

hiranya911 commented Feb 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

The linter fails the build if it detects at least one error. But looks like the linter passed on this one, which is good. I see the following in the last Travis build log:

$ if [[ "$PY_VERSION" == '2' ]]; then ./lint.sh all; fi
Running linter on module firebase_admin
Running linter on module tests
Running linter on module integration
Running linter on module snippets

We have more snippets at https://github.com/firebase/quickstart-python. I think we should move them here as well.

samtstern commented Feb 20, 2018

Copy link
Copy Markdown
Contributor Author

@hiranya911 I added all the relevant quickstart-python snippets here and also moved the files around to be in subfolders. Lint gets 10/10 now.

samtstern commented Feb 20, 2018

Copy link
Copy Markdown
Contributor Author

However the 581a9dc should have failed due to lint, and it did not...

samtstern commented Feb 20, 2018

Copy link
Copy Markdown
Contributor Author

I'll wait for @hiranya911 to merge.

hiranya911 approved these changes Feb 20, 2018
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Nit: Some files are missing the license header.

samtstern merged commit 432a207 into master Feb 20, 2018
carsongee pushed a commit to carsongee/firebase-admin-python that referenced this pull request Mar 13, 2018
Add snippets to the admin repo (firebase#130)
524f0ee
This was referenced May 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
hiranya911 hiranya911 approved these changes
avishalom avishalom approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

samtstern

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL