Handling FCM canonical error codes - #131
Merged
hiranya911 merged 1 commit intoMar 1, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
avishalom
approved these changes
Mar 1, 2018
Copy link
Copy Markdown
|
@hiranya911 when are you planning on releasing this change? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@hiranya911 @avishalom can you please tell when are you planning on releasing this? |
Sorry, something went wrong.
carsongee
pushed a commit
to carsongee/firebase-admin-python
that referenced
this pull request
Mar 13, 2018
Copy link
Copy Markdown
Contributor
Author
|
@dhruv-aggarwal We'll try to get a release out this week. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error codes defined in https://firebase.google.com/docs/reference/fcm/rest/v1/ErrorCode are embedded in the details section of the error response. The top-level error code (status field in the response) may take additional values such as NOT_FOUND and UNAUTHENTICATED (the so called canonical error codes):
{ "error":{ "code":404, "message":"Requested entity was not found.", "status":"NOT_FOUND", "details: [ { "@type":"type.googleapis.com/google.firebase.fcm.v1.FcmError", "errorCode":"UNREGISTERED" } ] } }This PR updates the FCM implementation to handle these additional error codes and map them to correct client-side errors.