FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added support for timeouts in messaging module by carsongee · Pull Request #132 · firebase/firebase-admin-python · GitHub

Added support for timeouts in messaging module - #132

Merged
hiranya911 merged 1 commit into
firebase:masterfrom
AFFOA:feature/messaging_timeout
Mar 9, 2018
Merged

Added support for timeouts in messaging module#132
hiranya911 merged 1 commit into
firebase:masterfrom
AFFOA:feature/messaging_timeout

Conversation

Copy link
Copy Markdown
Contributor

This adds support for using the httpTimeout option from the App for specifying client timeout parameters inside of the messaging module.

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

Copy link
Copy Markdown
Contributor Author

I signed it!

Copy link
Copy Markdown

CLAs look good, thanks!

carsongee force-pushed the feature/messaging_timeout branch from 861b9ca to d66b274 Compare March 8, 2018 19:33

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @carsongee. This looks great. Can you also add a test case? Something similar to: https://github.com/firebase/firebase-admin-python/blob/master/tests/test_db.py#L597

hiranya911 self-assigned this Mar 8, 2018

Copy link
Copy Markdown
Contributor Author

I'll try and get that test written tomorrow, thanks for the consideration ✨

carsongee force-pushed the feature/messaging_timeout branch 4 times, most recently from 0f6cf00 to f0247c4 Compare March 9, 2018 00:08

Copy link
Copy Markdown
Contributor Author

tests added

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please fix the lint error, and then this is good to go.

Comment thread tests/test_messaging.py Outdated
assert len(recorder) == 1
assert recorder[0].method == 'POST'
assert recorder[0].url == self._get_url('explicit-project-id')
assert recorder[0]._extra_kwargs['timeout'] == None

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Implement this check with is None to avoid the lint error: https://travis-ci.org/firebase/firebase-admin-python/jobs/351093644#L552

carsongee force-pushed the feature/messaging_timeout branch from f0247c4 to a90f4c8 Compare March 9, 2018 03:54
hiranya911 merged commit 328036c into firebase:master Mar 9, 2018
carsongee added a commit to carsongee/firebase-admin-python that referenced this pull request Mar 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL