| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Sorry, something went wrong.
|
I signed it! |
Sorry, something went wrong.
|
CLAs look good, thanks! |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks @carsongee. This looks great. Can you also add a test case? Something similar to: https://github.com/firebase/firebase-admin-python/blob/master/tests/test_db.py#L597
Sorry, something went wrong.
|
I'll try and get that test written tomorrow, thanks for the consideration ✨ |
Sorry, something went wrong.
|
tests added |
Sorry, something went wrong.
There was a problem hiding this comment.
Please fix the lint error, and then this is good to go.
Sorry, something went wrong.
| assert len(recorder) == 1 | ||
| assert recorder[0].method == 'POST' | ||
| assert recorder[0].url == self._get_url('explicit-project-id') | ||
| assert recorder[0]._extra_kwargs['timeout'] == None |
There was a problem hiding this comment.
Implement this check with is None to avoid the lint error: https://travis-ci.org/firebase/firebase-admin-python/jobs/351093644#L552
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This adds support for using the httpTimeout option from the App for specifying client timeout parameters inside of the messaging module.