FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Migrating Auth API to the new Identity Toolkit endpoint by hardikns · Pull Request #256 · firebase/firebase-admin-python · GitHub

/ firebase-admin-python Public

Migrating Auth API to the new Identity Toolkit endpoint - #256

Merged
hiranya911 merged 5 commits into
firebase:masterfrom
hardikns:hs_new_id_toolkit
Feb 7, 2019
ConversationCommits (5)ChecksFiles changed
Merged

Migrating Auth API to the new Identity Toolkit endpoint#256
hiranya911 merged 5 commits into
firebase:masterfrom
hardikns:hs_new_id_toolkit

Conversation

hardikns commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

Using the new Identity Toolkit REST endpoint for user management features. This is as per corresponding change in java (firebase/firebase-admin-java#220) and node SDKs.

hardikns closed this Feb 4, 2019
hardikns reopened this Feb 4, 2019

hardikns commented Feb 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@hiranya911 Can you please help on how to run Integration tests? I would like to do those before I submit the PR.

Specifically on what are the contents of the --cert (is this the standard service account json?) and --apikey file.

hiranya911 commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

@hardikns Check the CONTRIBUTING.md file for instructions.

hardikns commented Feb 6, 2019

Copy link
Copy Markdown
Contributor Author

@hiranya911 Can you please review the change? I plan to submit another in few days with changes around ooblink.

Meanwhile I did not find any documentation of the new Identity Toolkit. If you can point to the same that would help.

hiranya911 commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

@hardikns thanks for doing this. I will review this sometime this week.

@bojeil-google any pointers to the documentation of the new ID toolkit API?

hiranya911 self-assigned this Feb 6, 2019
hiranya911 suggested changes Feb 6, 2019
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks pretty solid. Just a couple of minor changes needed.

Comment thread CHANGELOG.md Outdated
Comment thread firebase_admin/auth.py Outdated
Comment thread tests/test_user_mgt.py Outdated
hiranya911 approved these changes Feb 7, 2019
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks @hardikns for the contribution.

hiranya911 merged commit 32d7dcd into firebase:master Feb 7, 2019
hardikns deleted the hs_new_id_toolkit branch February 13, 2019 19:57

hardikns commented Feb 13, 2019

Copy link
Copy Markdown
Contributor Author

@bojeil-google can you please point me to the documentation on the new ID toolkit API?

bojeil-google commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

If you mean the REST API, it is not yet documented.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
hiranya911 hiranya911 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL