FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add rate limiting exceptions by skion · Pull Request #695 · firebase/firebase-admin-python · GitHub

/ firebase-admin-python Public

Add rate limiting exceptions - #695

Merged
jonathanedey merged 1 commit into
firebase:masterfrom
fynchmobility:rate-limiting
Mar 6, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Add rate limiting exceptions#695
jonathanedey merged 1 commit into
firebase:masterfrom
fynchmobility:rate-limiting

Conversation

skion commented Apr 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This adds two exception types to enable users to detect rate limited calls which were previously swallowed and converted into a generic InvalidArgumentError, making it impossible to detect rate limiting situations and pass that information through to the end user.

This is being discussed in #666.

I chose to inherit from the ResourceExhaustedError base exception, which seemed to make most sense.

google-cla Bot commented Apr 13, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

skion marked this pull request as ready for review April 13, 2023 20:34

skion commented May 1, 2023

Copy link
Copy Markdown
Contributor Author

@pragatimodi Since you are assigned to #666, would you be able to check this out?

skion force-pushed the rate-limiting branch 2 times, most recently from 190b7c8 to 4ad0339 Compare November 15, 2023 20:54

skion commented Feb 27, 2024

Copy link
Copy Markdown
Contributor Author

@jonathanedey I see you are mostly maintaining this repo now, is this something you could have a look at?

lahirumaramba linked an issue Mar 5, 2024 that may be closed by this pull request
[FR] Improve exception handling for rate limiting #666
Closed
pragatimodi self-requested a review March 5, 2024 17:07
jonathanedey approved these changes Mar 5, 2024
View reviewed changes

jonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @skion, This looks great. Thank you so much for your patience in getting this added!

jonathanedey merged commit a14ca32 into firebase:master Mar 6, 2024
lahirumaramba mentioned this pull request Mar 6, 2024
Merged
skion deleted the rate-limiting branch June 24, 2024 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lahirumaramba lahirumaramba approved these changes
jonathanedey jonathanedey approved these changes
+1 more reviewer
pragatimodi pragatimodi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FR] Improve exception handling for rate limiting

4 participants

Back | FazBrowse Home | New Git URL