feat(fcm): Add send_each and send_each_for_multicast for FCM batch send - #706
Merged
Doris-Ge merged 3 commits intoJun 9, 2023
Merged
feat(fcm): Add send_each and send_each_for_multicast for FCM batch send#706Doris-Ge merged 3 commits into
Doris-Ge merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
`send_each` vs `send_all` 1. `send_each` sends one HTTP request to V1 Send endpoint for each message in the list. `send_all` sends only one HTTP request to V1 Batch Send endpoint to send all messages in the array. 2. `send_each` uses concurrent.futures.ThreadPoolExecutor to run and wait for all `request` calls to complete and construct a `BatchResponse`. An `request` call to V1 Send endpoint either completes with a success or throws an exception. So if an exception is thrown out, the exception will be caught in `send_each` and turned into a `SendResponse` with an exception. Therefore, unlike `send_all`, `send_each` does not always throw an exception for a total failure. It can also return a `BatchResponse` with only exceptions in it. `send_each_for_multicast` calls `send_each` under the hood.
* Add integration tests for send_each and send_each_for_multicast Add test_send_each, test_send_each_500 and test_send_each_for_multicast * chore: Fix pypy tests (#694) * chore(auth): Update Auth API to `v2` (#691) * `v2beta1` -> `v2` * Reverting auto formatting changes * undo auto formatting * Add release notes to project URLs in PyPI (#679) It's useful to be able to navigate to the release notes easily from the package index when upgrading. "Release Notes" is a special keyword that will have the scroll icon in the project page. A random example: * https://pypi.org/project/streamlit/ * https://github.com/streamlit/streamlit/blob/815a3ea6fa3e7f9099b479e8365bd3a5874ddc35/lib/setup.py#L111 Co-authored-by: Lahiru Maramba <llahiru@gmail.com> --------- Co-authored-by: Lahiru Maramba <llahiru@gmail.com> Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com> Co-authored-by: Samuel Dion-Girardeau <samueldg@users.noreply.github.com>
kevinthecheung
approved these changes
Jun 8, 2023
lahirumaramba
approved these changes
Jun 9, 2023
lahirumaramba
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM! Thank you!
Sorry, something went wrong.
akhilnarang
added a commit
to akhilnarang/vlrgg-scraper
that referenced
this pull request
Jul 17, 2023
The latter is now deprecated: firebase/firebase-admin-python#706 Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Copy link
Copy Markdown
with concurrent.futures.ThreadPoolExecutor(max_workers=len(message_data)) as executor:
responses = [resp for resp in executor.map(send_data, message_data)]
return BatchResponse(responses)As we can see that the max number can ThreadPoolExecutor take is 500 and we always split our chunks as 500. So it throws "Unknown error while making remote service calls: can't start new thread". Isnt that dangerous to trying to open 500 threads ? with 500 chunks limit ? @Doris-Ge @lahirumaramba |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_each vs send_all
send_each_for_multicast calls send_each under the hood.
RELEASE NOTE: send_all() and send_multicast() APIs are now deprecated. Use send_each() and send_each_for_multicast() APIs instead.