FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(auth): Update `ActionCodeSettings` to support `link_domain` and deprecate `dynamic_link_domain` by huwmartin · Pull Request #884 · firebase/firebase-admin-python · GitHub

/ firebase-admin-python Public

feat(auth): Update ActionCodeSettings to support link_domain and deprecate dynamic_link_domain - #884

Merged
jonathanedey merged 9 commits into
firebase:masterfrom
huwmartin:action-code-settings-link-domain
Jul 23, 2025
ConversationCommits (9)ChecksFiles changed
Merged

feat(auth): Update ActionCodeSettings to support link_domain and deprecate dynamic_link_domain#884
jonathanedey merged 9 commits into
firebase:masterfrom
huwmartin:action-code-settings-link-domain

Conversation

huwmartin commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Discussion

Firebase Dynamic Links will stop working August 25th 2025.

Migration instructions indicate that to use a custom domain one should update usage of ActionCodeSettings to use linkDomain, see also in the Firebase Admin docs.

We currently depend upon generate_sign_in_with_email_link to generate email links, firebase-admin-python hasn't been updated with link_domain and currently only supports dynamic_link_domain, firebase-admin-node has been updated with support for linkDomain so I assume this should be officially supported, please let me know if this is not the case.

See #883.

This PR updates ActionCodeSettings to accept link_domain and updates encode_action_code_settings to handle link_domain when constructing request payload. I have also added definition for new InvalidHostingLinkDomainError error.

huwmartin mentioned this pull request Jun 12, 2025
Closed

huwmartin commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

@lahirumaramba @pashanka see here re: #883. In my org we're currently relying on this via a fork and would be great to get into main release.

Xiaoshouzi-gh reviewed Jul 1, 2025
View reviewed changes

Xiaoshouzi-gh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for putting this together!

Comment thread firebase_admin/_auth_utils.py Outdated
Xiaoshouzi-gh approved these changes Jul 7, 2025
View reviewed changes

Xiaoshouzi-gh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for putting this together!

Xiaoshouzi-gh reviewed Jul 7, 2025
View reviewed changes

Xiaoshouzi-gh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please fix the lint: https://github.com/firebase/firebase-admin-python/actions/runs/16007848807/job/45494220646?pr=884

huwmartin force-pushed the action-code-settings-link-domain branch from 1d9d933 to dfce7c1 Compare July 7, 2025 17:33
lahirumaramba self-assigned this Jul 8, 2025
jonathanedey self-requested a review July 14, 2025 14:14
jonathanedey requested changes Jul 18, 2025
View reviewed changes

jonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @huwmartin for putting this together! Overall LGTM with one minor change below.

Comment thread firebase_admin/_user_mgt.py Outdated
jonathanedey requested review from egilmorez and removed request for OrlandriaH-G July 23, 2025 15:12
jonathanedey approved these changes Jul 23, 2025
View reviewed changes

jonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Please address the lint error and update the branch, Thanks!

egilmorez approved these changes Jul 23, 2025
View reviewed changes

egilmorez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LG, thanks!

huwmartin commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

@jonathanedey thanks, lots of other issues when running ./lint.sh all locally, CI appears to only lint touched lines(?), so difficult to tell what will snag 😄 I've updated all of ActionCodeSettings.__init__ for consistency.

jonathanedey commented Jul 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@huwmartin, no worries, those were mainly because the branch was out of date. We made some lint changes in or last release and the CI here are using those settings. Thanks again for you contribution!

jonathanedey changed the title Update ActionCodeSettings to support link_domain feat(auth) Update ActionCodeSettings to support link_domain and deprecate dynamic_link_domain Jul 23, 2025
jonathanedey merged commit 4fa2918 into firebase:master Jul 23, 2025
10 checks passed
jonathanedey changed the title feat(auth) Update ActionCodeSettings to support link_domain and deprecate dynamic_link_domain feat(auth): Update ActionCodeSettings to support link_domain and deprecate dynamic_link_domain Jul 23, 2025
jonathanedey pushed a commit that referenced this pull request Aug 13, 2025
feat(auth) Update ActionCodeSettings to support link_domain and d…
9eba3e0 
…eprecate `dynamic_link_domain` (#884)

* Add link_domain to ActionCodeSettings; update encode_action_code_settings to handle link_domain

* Add handling for InvalidHostingLinkDomainError

* Add deprecation warning for dynamic_link_domain

* Update error message for InvalidHostingLinkDomainError

* Fix lint

* Add type hints to ActionCodeSettings

* Fix f-string lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jonathanedey jonathanedey approved these changes
+3 more reviewers
Xiaoshouzi-gh Xiaoshouzi-gh approved these changes
errkk errkk approved these changes
egilmorez egilmorez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

lahirumaramba

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL