Prepare VertexAI SDK for release - #6941
Merged
daymxn merged 15 commits intoMay 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Sorry, something went wrong.
daymxn
enabled auto-merge (squash)
May 6, 2025 21:30
Copy link
Copy Markdown
Collaborator
Coverage Report 1Affected ProductsNo changes between base commit (548dc28) and merge commit (6b8bd18).Test Logs |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 18 files - 24 18 suites - 24 38s ⏱️ -44s Results for commit 5518099. ± Comparison against base commit 548dc28. This pull request removes 324 and adds 88 tests. Note that renamed tests count towards both.com.google.firebase.remoteconfig.ConfigTests ‑ Custom Signals builder support multiple types com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance() com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance(FirebaseApp, region) com.google.firebase.remoteconfig.ConfigTests ‑ FirebaseRemoteConfigSettings builder works com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns default value when key doesn't exist com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns value when key exists com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutDouble com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutDuplicateKeys com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutLong com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutMixedTypes … com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration com.google.firebase.vertexai.SchemaTests ‑ full schema declaration com.google.firebase.vertexai.SerializationTests ‑ test Candidate serialization as Json com.google.firebase.vertexai.SerializationTests ‑ test GenerateContentResponse serialization as Json com.google.firebase.vertexai.SerializationTests ‑ test Schema serialization as Json com.google.firebase.vertexai.SerializationTests ‑ test countTokensResponse serialization as Json com.google.firebase.vertexai.SerializationTests ‑ test modalityTokenCount serialization as Json com.google.firebase.vertexai.VertexAIStreamingSnapshotTests ‑ citation parsed correctly … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Size Report 1Affected Products
Test Logs |
Sorry, something went wrong.
rlazo
reviewed
May 7, 2025
Comment thread
firebase-vertexai/CHANGELOG.md
Outdated
daymxn
disabled auto-merge
May 7, 2025 15:12
…irebase-android-sdk into daymon-prepare-vertex
rlazo
reviewed
May 7, 2025
Comment thread
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/Chat.kt
Outdated
…/Chat.kt Co-authored-by: Rodrigo Lazo <rlazo@users.noreply.github.com>
rlazo
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per b/414829218,
This ensures the Vertex AI SDK is properly aligned for the upcoming release. More specifically, this PR does the following: