Add headers to be able to track bidi usage - #6939
Merged
VinayGuthal merged 3 commits intoMay 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Generated by 🚫 Danger |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Coverage Report 1Affected ProductsNo changes between base commit (525f293) and merge commit (23dd81b).Test Logs |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 22 files - 1 034 22 suites - 1 034 34s ⏱️ - 34m 45s Results for commit a9c16ec. ± Comparison against base commit 525f293. This pull request removes 5874 tests.com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
rlazo
reviewed
May 6, 2025
Copy link
Copy Markdown
Collaborator
Size Report 1Affected Products
Test Logs |
Sorry, something went wrong.
rlazo
approved these changes
May 6, 2025
daymxn
added a commit
that referenced
this pull request
May 7, 2025
Per [b/414829218](https://b.corp.google.com/issues/414829218), This ensures the Vertex AI SDK is properly aligned for the upcoming release. More specifically, this PR does the following: - Adds deprecation notices for all the public classes and interfaces, **besides** the root `FirebaseVertexAI` class and the relevant extension methods. - Updates the golden file version. - Adds the change from #6925 for working around invalid `SafetyRating`(s). - Adds a changelog entry that aligns with the deprecation notices. - Adds the changes from #6939 for tracking bidi usage. - Adds the changes from #6910 for aligning the bidi protos. --------- Co-authored-by: Rodrigo Lazo <rlazo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally we were not tracking bidi usage in android. This PR enables it by adding certain headers when the initial websocket connection is made. There was some refractoring done wrt to extract out the part which just adds the headers from the applyCommonConfiguration function