FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Token-changed listeners for iOS AppCheck by AlmostMatt · Pull Request #1172 · firebase/firebase-cpp-sdk · GitHub

/ firebase-cpp-sdk Public

Token-changed listeners for iOS AppCheck - #1172

Merged
AlmostMatt merged 16 commits into
mainfrom
amatt-ios-appcheck-listeners
Dec 20, 2022
ConversationCommits (16)ChecksFiles changed
Merged

Token-changed listeners for iOS AppCheck#1172
AlmostMatt merged 16 commits into
mainfrom
amatt-ios-appcheck-listeners

Conversation

AlmostMatt commented Dec 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Implements token-changed listeners for the iOS implementation of AppCheck

Testing

Added integration test cases to verify token-changed notification is received and token-changed listeners are called.
Integration tests passed when running locally.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

AlmostMatt added the skip-release-notes Skip release notes check label Dec 16, 2022
a-maurice reviewed Dec 17, 2022
View reviewed changes
Comment thread app_check/src/ios/app_check_ios.mm
Comment thread app_check/src/ios/app_check_ios.mm
AlmostMatt requested a review from a-maurice December 19, 2022 21:39
AlmostMatt enabled auto-merge (squash) December 20, 2022 19:48
AlmostMatt merged commit c380832 into main Dec 20, 2022
github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Dec 20, 2022

github-actions Bot commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @AlmostMatt on commit c380832
Last updated: Tue Dec 20 14:18 PST 2022
View integration test log & download artifacts

Failures Configs
gma [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target](2 failed tests)  FirebaseGmaTest.TestRewardedAdLoad
  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
storage [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target](1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

github-actions Bot added the tests: failed This PR's integration tests failed. label Dec 20, 2022
firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 20, 2022
AlmostMatt deleted the amatt-ios-appcheck-listeners branch January 19, 2023 21:28
firebase locked and limited conversation to collaborators Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

a-maurice a-maurice approved these changes

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL