Implement setDefaultEventParameters method in C++ Analytics API - #1698
Draft
jonsimantov wants to merge 9 commits into
Draft
Implement setDefaultEventParameters method in C++ Analytics API#1698jonsimantov wants to merge 9 commits into
jonsimantov wants to merge 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit adds the method to the C++ Analytics API. This method allows setting default event parameters, mirroring functionality in the iOS and Android SDKs. The implementation covers: - iOS: Using Objective-C++ to call the - Android: Using JNI to call the - Desktop: A stub implementation for other platforms. Unit tests and integration tests were added to ensure the change works as intended. A release note was added for the next release (v12.7.0) in - Analytics: Added support for default parameters to be sent with each event. This change lets you use to set default parameters to be sent with each event. - General (iOS): Update to Firebase Cocoapods version 11.9.0. - General (Android): Update to Firebase Android BoM version 33.10.0. All the references to in the test files were corrected to have the namespace added.
Copy link
Copy Markdown
❌ Integration test FAILEDRequested by @jonsimantov on commit 4371814
Add flaky tests to go/fpl-cpp-flake-tracker |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the method to the C++
Analytics API. This method allows setting default event parameters, mirroring functionality in the iOS and Android SDKs.
The implementation covers:
Testing
Unit tests and integration tests were added to ensure the change works as intended.
Type of Change
Place an x the applicable box:
Notes