Guard remote config response parsing from empty FlatBuffer - #1790
Guard remote config response parsing from empty FlatBuffer#1790triplef wants to merge 2 commits into
Conversation
Sorry, something went wrong.
Summary of ChangesHello @triplef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a critical safeguard to the Remote Config client, specifically within the MarkCompleted() method. By adding a check for empty FlatBuffer data, it prevents potential crashes that would occur if the system attempted to process a response without any content. This ensures the stability and robustness of the desktop Remote Config client when handling various server responses. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request aims to fix a crash when parsing an empty remote config response by adding a guard before accessing the FlatBuffer. While the intention is correct, the added check for an empty buffer (GetSize() == 0) is not sufficient to prevent all out-of-bounds access. A malformed response with a very small (but non-zero) body could still cause a crash. I've provided a suggestion to make this check more robust by ensuring the buffer is large enough to contain a root pointer.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
Description
Guard RemoteConfigResponse::MarkCompleted() from attempting to read a FlatBuffer when the builder holds no data, preventing the desktop Remote Config client from crashing on empty responses.
Fixes #1433.
———
Testing
Not run (Remote Config desktop integration tests depend on internal credentials; change is limited to an early-exit guard).
———
Type of Change
———