FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Removing google play requirement. by vimanyu · Pull Request #361 · firebase/firebase-cpp-sdk · GitHub

/ firebase-cpp-sdk Public

Removing google play requirement. - #361

Merged
jonsimantov merged 4 commits into
mainfrom
feature/remove-google-play-requirement
Apr 12, 2021
ConversationCommits (4)ChecksFiles changed
Merged

Removing google play requirement.#361
jonsimantov merged 4 commits into
mainfrom
feature/remove-google-play-requirement

Conversation

vimanyu commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Firebase Android SDKs for Auth, Database, Storage, Functions do not require Google Play Services anymore.
https://firebase.google.com/docs/android/android-play-services

Removing checks for Google Play services for these products from the C++ SDK.
Tested by running integration tests on,

Addresses firebase/quickstart-unity#975

vimanyu requested review from a-maurice and chkuang-g April 9, 2021 19:47
google-cla Bot added the cla: yes label Apr 9, 2021
vimanyu requested a review from jonsimantov April 9, 2021 19:47

vimanyu commented Apr 9, 2021

Copy link
Copy Markdown
Contributor Author

Not sure if we still need the App callback but I left it in there for now. Let me know if that can be safely removed too.

a-maurice previously approved these changes Apr 9, 2021
View reviewed changes

jonsimantov commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Not sure if we still need the App callback but I left it in there for now. Let me know if that can be safely removed too.

What do you mean by "App callback"?

jonsimantov suggested changes Apr 12, 2021
View reviewed changes

jonsimantov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you add an update to the readme file?

jonsimantov reviewed Apr 12, 2021
View reviewed changes
Comment thread release_build_files/readme.md Outdated
- General: Fixed rare crashes at application exit when destructors were
being executed
([#345](https://github.com/firebase/firebase-cpp-sdk/pull/345)).
- General: Removed checks for Google Play Services in C++ for Auth, Database,

jonsimantov Apr 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

General (Android):

jonsimantov Apr 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also, it should be spelled "Google Play services" (with a lower-case "s")

jonsimantov commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Not sure if we still need the App callback but I left it in there for now. Let me know if that can be safely removed too.

What do you mean by "App callback"?

I figured out what you meant - those are needed for the Unity SDK to initialize the various C++ modules, I believe, and should be kept in place for now.

jonsimantov merged commit 9e448d0 into main Apr 12, 2021
jonsimantov deleted the feature/remove-google-play-requirement branch April 12, 2021 19:22
firebase locked and limited conversation to collaborators May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

chkuang-g Awaiting requested review from chkuang-g
a-maurice Awaiting requested review from a-maurice
1 more reviewer
jonsimantov jonsimantov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL