Change Xcode version from 12.2 to 12.4 to ensure GitHub support. by jonsimantov · Pull Request #774 · firebase/firebase-cpp-sdk · GitHub

Description

Provide details of the change, and generalize the change in the PR title above.

GitHub Mac runners are dropping Xcode 12.2 support. Xcode 12.4 is the minimum Xcode 12 version available.

Also updates the integration test workflow to respect the xcode version.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running cpp-packaging and integration_tests workflows.

Type of Change

Place an x the applicable box:

Bug fix. Add the issue # below if applicable.
New feature. A non-breaking change which adds functionality.
Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

Packaging run: https://github.com/firebase/firebase-cpp-sdk/actions/runs/1527435519

✅ Integration test succeeded!

Requested by @jonsimantov on commit 726cc7d
Last updated: Wed Dec 1 20:08 PST 2021
View integration test log & download artifacts

This reverts commit 8da9b3f.

why there's extra two entries?

This makes it so it doesn't repeat the linux/windows jobs even if the matrix contains xcode 11.7, 12.4, and 12.5.1. (previously it was omitting 12.4, which is the actual version we use now, so this swaps it to the others - previously there was a bug where 11.7 was missing here.)

To clarify: the expanded matrix will have the following (simplified) list of targets:

macos - xcode 11.7
windows - xcode 11.7
ubuntu - xcode 11.7
macos - xcode 12.4
windows - xcode 12.4
ubuntu - xcode 12.4
macos - xcode 12.5.1
windows - xcode 12.5.1
ubuntu - xcode 12.5.1

These "excludes" entries ensure that only one set of ubuntu and windows will be run. And it can't exclude 12.4, because 12.4 is now the one that runs in the non-expanded matrix.

Manually re-running the failed tests succeeded: https://github.com/firebase/firebase-cpp-sdk/runs/4389628290?check_suite_focus=true

* Fix link in readme (#768) * update test devices (#757) * Timeout and Retry FTL failures and mark flakiness * Update C++ SDK version to 8.8.0. * Add Analytics header update to iOS SDK update. (#775) * Add Analytics header update to iOS SDK update. * Update Android dependencies - Wed Dec 01 2021 (#773) ### Android - com.google.firebase.firebase_database → 20.0.3 - com.google.firebase.firebase_perf → 20.0.4 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1527401903). Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> * Fix typo in log output. * Change Xcode version from 12.2 to 12.4 to ensure GitHub support. (#774) * Change Xcode version from 12.2 to 12.4 to ensure GitHub support. * Fix integration tests workflow to respect xcode_version in matrix. * Add extra newline to header comment. * Update iOS dependencies - Thu Dec 02 2021 (#779) * Update iOS dependencies - Thu Dec 02 2021 ### iOS - Firebase/Analytics → 8.10.0 - Firebase/Auth → 8.10.0 - Firebase/Core → 8.10.0 - Firebase/Crashlytics → 8.10.0 - Firebase/Database → 8.10.0 - Firebase/DynamicLinks → 8.10.0 - Firebase/Firestore → 8.10.0 - Firebase/Functions → 8.10.0 - Firebase/Installations → 8.10.0 - Firebase/Messaging → 8.10.0 - Firebase/RemoteConfig → 8.10.0 - Firebase/Storage → 8.10.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1528664697). * Add missing copyright lines. * Add Firestore release note. Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: Jon Simantov <jsimantov@google.com> * Properly convert milliseconds to seconds (#767) * Properly convert milliseconds to seconds Currently, a value expressed in milliseconds is directly assigned to a variable which is supposed to store seconds and it's later converted to mills again. Thus, convert properly upon assignment * Update readme.md * Change LogDebug to NSLog in app's swizzling code. (#783) * Change LogDebug to NSLog. * Change log message. * Add comment. * Add copyright line when importing Analytics iOS headers, if missing (#780) * Add copyright line to iOS headers * Make copyright conditional to whether the file already has one. * Also set Xcode version explicitly in Android workflow. (#786) * Timeout & retry "install integration test deps" step (#785) * Format code. Co-authored-by: Борис Рязанцев <88411548+borisssoft@users.noreply.github.com> Co-authored-by: Mou Sun <69009538+sunmou99@users.noreply.github.com> Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com> Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: pawelsnk <pawelsnk@o2.pl>

Change Xcode version from 12.2 to 12.4 to ensure GitHub support.

73f1ba6

google-cla Bot added the cla: yes label Dec 1, 2021

jonsimantov requested a review from cynthiajoan December 1, 2021 19:23

Fix iOS workflows too.

598ba9d

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 1, 2021

cynthiajoan approved these changes Dec 1, 2021

View reviewed changes

Fix capitalization to look all fancy-like.

8fbb364

github-actions Bot added the tests: failed This PR's integration tests failed. label Dec 1, 2021

jonsimantov removed tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Dec 1, 2021

Fix integration tests workflow to respect xcode_version in matrix.

7cf60ac

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 1, 2021

Debug log

66b67d6

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot removed the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

Fix typo

1989328

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot removed the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

Remove extra array subscript

304e167

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot removed the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

Fix yml

0477e8c

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot removed the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot removed the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

Fix yml again again

8146d93

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot removed the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

Move array access later in case we make it a proper matrix in the future

03192ca

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot removed the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

Add xcode setting to tvos

0371754

jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

github-actions Bot removed the tests-requested: quick Trigger a quick set of integration tests. label Dec 1, 2021

jonsimantov enabled auto-merge (squash) December 1, 2021 23:38

Fix desktop test to not omit ubuntu.

2bb2a09

github-actions Bot added the tests: failed This PR's integration tests failed. label Dec 2, 2021

jonsimantov added 3 commits December 1, 2021 16:35

Change tvOS simulator version to 14.3, 14.0 is out of date.

5af1503

Also set xcode version on test machines.

8da9b3f

Revert "Also set xcode version on test machines."

8d9f01f

This reverts commit 8da9b3f.

cynthiajoan reviewed Dec 2, 2021

View reviewed changes

Actually set the xcode version on test jobs

7886108

jonsimantov removed tests: failed This PR's integration tests failed. tests: in-progress This PR's integration tests are in progress. labels Dec 2, 2021

jonsimantov merged commit 726cc7d into main Dec 2, 2021

github-actions Bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Dec 2, 2021

firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 2, 2021

github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Dec 2, 2021

jonsimantov deleted the bugfix/xcode_version branch December 2, 2021 05:41

firebase locked and limited conversation to collaborators Jan 1, 2022

@@ @@ -74,9 +74,13 @@ jobs: @@
                           architecture: "x86"
                         # Xcode excludes -- allow only one on osx and linux
                         - os: ubuntu-latest

Change Xcode version from 12.2 to 12.4 to ensure GitHub support. by jonsimantov · Pull Request #774 · firebase/firebase-cpp-sdk · GitHub

Uh oh!

Change Xcode version from 12.2 to 12.4 to ensure GitHub support. - #774

Change Xcode version from 12.2 to 12.4 to ensure GitHub support.#774
jonsimantov merged 17 commits into
mainfrom
bugfix/xcode_version

jonsimantov commented Dec 1, 2021 •
edited
Loading

Uh oh!

Uh oh!

jonsimantov commented Dec 1, 2021

Uh oh!

github-actions Bot commented Dec 1, 2021 •
edited
Loading

Uh oh!

Uh oh!

cynthiajoan Dec 2, 2021

Uh oh!

jonsimantov Dec 2, 2021

Uh oh!

jonsimantov Dec 2, 2021 •
edited
Loading

Uh oh!

Uh oh!

jonsimantov commented Dec 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Change Xcode version from 12.2 to 12.4 to ensure GitHub support. by jonsimantov · Pull Request #774 · firebase/firebase-cpp-sdk · GitHub

Uh oh!

Change Xcode version from 12.2 to 12.4 to ensure GitHub support. - #774

Change Xcode version from 12.2 to 12.4 to ensure GitHub support.#774jonsimantov merged 17 commits intomainfirebase/firebase-cpp-sdk:mainfrom bugfix/xcode_versionfirebase/firebase-cpp-sdk:bugfix/xcode_versionCopy head branch name to clipboard

Conversation

jonsimantov commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Type of Change

Notes

Uh oh!

jonsimantov commented Dec 1, 2021

Uh oh!

github-actions Bot commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Integration test succeeded!

Uh oh!

cynthiajoan Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

jonsimantov Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

jonsimantov Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonsimantov commented Dec 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Change Xcode version from 12.2 to 12.4 to ensure GitHub support.#774
jonsimantov merged 17 commits into
mainfrom
bugfix/xcode_version

jonsimantov commented Dec 1, 2021 •
edited
Loading

github-actions Bot commented Dec 1, 2021 •
edited
Loading

jonsimantov Dec 2, 2021 •
edited
Loading