Upgrade LevelDb dependency from a pinned commit to 1.23 - #886
Merged
dconeybe merged 3 commits intoApr 8, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
LevelDb version 1.23 is the first LevelDb release to include the pinned commit, google/leveldb@e0d5f83.
jonsimantov
reviewed
Apr 8, 2022
Comment thread
release_build_files/readme.md
Outdated
| ## Release Notes | ||
| ### Upcoming Release | ||
| - Changes | ||
| - Firestore/Database (desktop): Upgrade LevelDb dependency to 1.23 |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: we usually capitalize Desktop here.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done
Sorry, something went wrong.
jonsimantov
self-requested a review
April 8, 2022 15:50
jonsimantov
approved these changes
Apr 8, 2022
Copy link
Copy Markdown
✅ Integration test succeeded!Requested by @dconeybe on commit 8e37ccc |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LevelDb version 1.23 is the first LevelDb release to include the pinned commit, google/leveldb@e0d5f83.