firestore_snappy.patch.txt: fix linux gcc inlining build error - #895
Merged
dconeybe merged 3 commits intoApr 13, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
❌ Integration test FAILEDRequested by @dconeybe on commit fd054fa
Add flaky tests to go/fpl-cpp-flake-tracker |
Sorry, something went wrong.
cynthiajoan
previously approved these changes
Apr 13, 2022
github-actions
Bot
dismissed
cynthiajoan’s stale review
April 13, 2022 02:09
🍞 Dismissed stale approval on external PR.
cynthiajoan
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #885 and fixes the Snappy build on some older compilers (e.g. gcc-9.4.0 on linux).
This PR is based on this patch: google/snappy#128
The build error looks like this:
snappy.cc:1017:8: warning: always_inline function might not be inlinable [-Wattributes] 1017 | size_t AdvanceToNextTag(const uint8_t** ip_p, size_t* tag) { | ^~~~~~~~~~~~~~~~ snappy.cc: In function ‘std::pair<const unsigned char*, long int> snappy::DecompressBranchless(const uint8_t*, const uint8_t*, ptrdiff_t, T, ptrdiff_t) [with T = char*]’: snappy.cc:1017:8: error: inlining failed in call to always_inline ‘size_t snappy::AdvanceToNextTag(const uint8_t**, size_t*)’: function body can be overwritten at link time snappy.cc:1097:43: note: called from here 1097 | size_t tag_type = AdvanceToNextTag(&ip, &tag); | ~~~~~~~~~~~~~~~~^~~~~~~~~~~The fix is to explicitly mark AdvanceToNextTag() as inline.
e.g. https://github.com/firebase/firebase-unity-sdk/runs/5998971917