DO NOT MERGE: firestore.cmake: point at HEAD commit in master branch: https://githu… - #950
DO NOT MERGE: firestore.cmake: point at HEAD commit in master branch: https://githu…#950dconeybe wants to merge 5 commits into
Conversation
Sorry, something went wrong.
… see if it fixes build errors in CI: lambda_event_listener.h:23:10: fatal error: 'firebase/firestore/firestore_errors.h' file not found
…esn't take as long
…clude to see if it fixes build errors in CI: lambda_event_listener.h:23:10: fatal error: 'firebase/firestore/firestore_errors.h' file not found" This change didn't fix anything. This reverts commit 7343ab5.
|
@wu-hui Thanks for taking this over from me. For the Android build error, it looks like it may not be nicely handling the modifications of cmake/external/firestore.cmake that pin the dependency on firebase-ios-sdk to a specific commit. I have no idea why the windows-latest-Release-x64-static workflow is failing to find the firestore ctest targets. Enjoy! |
Sorry, something went wrong.
|
Now that Snappy support has been added to the iOS SDK (firebase/firebase-ios-sdk#9596), building at head is quite a bit more complicated. This would should instead be continued in #932, which does the work to modify this repo to no longer patch in Snappy support. |
Sorry, something went wrong.
Test PR to see if the build works at the HEAD of the iOS SDK. I will close this PR once the "testing" is done.