Divide everything into v1, v2, and common (unexported). - #1149
Merged
inlined merged 11 commits intoJun 27, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Did some refactoring, like putting `firebaseConfig` into common. This means we have absolutely no dependencies on v1 in common or v2. Some files are left at the root because they were modified in other CLs that are outstanding and I want to linearize the changes to minimize conflicts. While working, I removed some legacy workarounds that should no longer apply. For example, we no longer need to load fireaseConfig from runtime config because all supported versions of the CLI set the FIREBASE_CONFIG environment variable. This meant we could remove all of setup.ts because all monkeypatches were for outdated runtimes. Since there is no longer an environment change between importing v1/index and a subpackage, I've gone ahead and exported the providers for v1 to minimize customer frustration with the v1 namespace.
* Remove __trigger * Lint fixes
Did some refactoring, like putting `firebaseConfig` into common. This means we have absolutely no dependencies on v1 in common or v2. Some files are left at the root because they were modified in other CLs that are outstanding and I want to linearize the changes to minimize conflicts. While working, I removed some legacy workarounds that should no longer apply. For example, we no longer need to load fireaseConfig from runtime config because all supported versions of the CLI set the FIREBASE_CONFIG environment variable. This meant we could remove all of setup.ts because all monkeypatches were for outdated runtimes. Since there is no longer an environment change between importing v1/index and a subpackage, I've gone ahead and exported the providers for v1 to minimize customer frustration with the v1 namespace.
* Remove __trigger * Lint fixes
colerogers
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some refactoring, like putting firebaseConfig into common.
This means we have absolutely no dependencies on v1 in common or
v2. Some files are left at the root because they were modified
in other CLs that are outstanding and I want to linearize the
changes to minimize conflicts.
While working, I removed some legacy workarounds that should no
longer apply. For example, we no longer need to load fireaseConfig
from runtime config because all supported versions of the CLI
set the FIREBASE_CONFIG environment variable. This meant we
could remove all of setup.ts because all monkeypatches were for
outdated runtimes. Since there is no longer an environment
change between importing v1/index and a subpackage, I've gone
ahead and exported the providers for v1 to minimize customer
frustration with the v1 namespace.
Description
Code sample