FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Wrap v2 firestore functions with trace context by milo- · Pull Request #1440 · firebase/firebase-functions · GitHub

/ firebase-functions Public

Wrap v2 firestore functions with trace context - #1440

Merged
blidd-google merged 2 commits into
firebase:masterfrom
milo-:bugfix/wrap-v2-firestore-functions
Jul 13, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Wrap v2 firestore functions with trace context#1440
blidd-google merged 2 commits into
firebase:masterfrom
milo-:bugfix/wrap-v2-firestore-functions

Conversation

milo- commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

Description

Wrap handlers with trace context. Fixes #1439

blidd-google self-requested a review July 11, 2023 21:08
blidd-google suggested changes Jul 11, 2023
View reviewed changes

blidd-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, please update the changelog before merging changes.

milo- commented Jul 11, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @blidd-google, changelog added

milo- requested a review from blidd-google July 12, 2023 06:44
blidd-google approved these changes Jul 13, 2023
View reviewed changes

blidd-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great!

blidd-google merged commit 41d616f into firebase:master Jul 13, 2023
milo- deleted the bugfix/wrap-v2-firestore-functions branch July 19, 2023 18:37

lox commented Aug 5, 2023

Copy link
Copy Markdown

Might it be possible to get this released?

tonylampada commented Aug 26, 2023

Copy link
Copy Markdown

Is there a way I can import and use the wrap handler myself while this doesn't get released?

milo- commented Sep 10, 2023

Copy link
Copy Markdown
Contributor Author

@blidd-google Would it be possible to get this released? It would massively help debugging.

lox mentioned this pull request Oct 23, 2023
Closed

ciriousjoker commented Nov 3, 2023 •
edited
Loading

Copy link
Copy Markdown

@blidd-google It's been almost 4 months since you merged this, is there an eta for when this is released? Seems like #1331 is also blocked by this.

Nevermind, just realized there was an update to v4.5.0 17 hours ago which includes this lol.

ciriousjoker mentioned this pull request Nov 14, 2023
Closed
This was referenced May 24, 2024
Open
Closed
aravindvnair99 mentioned this pull request Jun 10, 2024
Closed
5twelve mentioned this pull request Aug 8, 2024
Open
This was referenced Sep 6, 2024
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
blidd-google blidd-google approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firestore Cloud functions V2 are missing a trace in logs

5 participants

Back | FazBrowse Home | New Git URL