Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Salakar
approved these changes
Jun 19, 2023
Salakar
marked this pull request as ready for review
June 19, 2023 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged first to fix the formatting CI failure: #108
Created a util function for normalizing Firestore document paths for each Firestore event listener.
fix #91
We tested the implementation by running Functions emulator. Here is a sample log of the path coming into the function before and after the path is normalized:
Print logs to show before and after we normalize the path:
Output on the console for "created", "written", "updated" & "deleted":
We've also created a unit test for the normalize function here