| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sorry, something went wrong.
|
Thanks @davidbuckman, do you mind writing a few tests along the line of: def test_supported_region_enum():
"""
Testing SupportedRegion enum
"""
assert options.SupportedRegion.EUROPE_WEST2 == "europe-west2"in this file, please? https://github.com/firebase/firebase-functions-python/blob/main/tests/test_options.py |
Sorry, something went wrong.
|
Hello @davidbuckman. Could you run the commands for formatting and fix the linting and push so that the CI is green? You can find these commands on the contributing guidelines page |
Sorry, something went wrong.
|
@russellwheatley anything else needed here? |
Sorry, something went wrong.
|
@davidbuckman since StrEnum was added in 3.11, and we are currently on 3.12 but supporting 3.10, this would be a breaking change. We've decided for now to just override the __str__ method manually on all enum classes, with the this PR being merged in on the next major version bump. For now, I'll leave this PR open and come back to it at a later date. Sorry for the inconvenience |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
SupportedRegion should be a StrEnum so that __str__ works as expected, e.g. in
https://github.com/firebase/functions-samples/blob/main/Python/taskqueues-backup-images/functions/main.py#L144-L168