fix: handle timestamps with no fractional seconds - #149
Merged
taeold merged 3 commits intoOct 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This is an incredible contribution - thank you so much! Do you mind fixing the linter errors so we can merge the PR? $ source venv/bin/activate $ python3.10 -m mypy . --fix |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Fixed lint! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@taeold friendly ping here, lint fixed and ready to run the CI process again |
Sorry, something went wrong.
taeold
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to rfc3339 timestamp protobuf could have optionally the fractional seconds. This change improves the current src/firebase_functions/private/util.py to convert the dates when there are no fractional seconds.
Fixes #148