feat: Add Auth Context enabled Firestore triggers - #184
Merged
blidd-google merged 15 commits intoApr 8, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
exaby73
marked this pull request as ready for review
March 19, 2024 23:15
pr-Mais
reviewed
Mar 20, 2024
Comment thread
src/firebase_functions/firestore_fn.py
Outdated
pr-Mais
reviewed
Mar 20, 2024
pr-Mais
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, we just need some unit tests if feasible.
Sorry, something went wrong.
exaby73
force-pushed
the
feat/auth-context
branch
from
1b1427e to
3799007
Compare
March 29, 2024 06:43
…o Event" This reverts commit 3799007.
blidd-google
reviewed
Apr 4, 2024
Comment thread
src/firebase_functions/firestore_fn.py
Outdated
blidd-google
self-requested a review
April 5, 2024 03:20
blidd-google
reviewed
Apr 5, 2024
blidd-google
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM except nit re: naming
Sorry, something went wrong.
pr-Mais
approved these changes
Apr 5, 2024
blidd-google
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.