feat: Implement before_email_sent and before_sms_sent blocking functions - #222
Open
exaby73 wants to merge 6 commits into
Open
feat: Implement before_email_sent and before_sms_sent blocking functions#222exaby73 wants to merge 6 commits into
exaby73 wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ve cyclic import issue with event types
exaby73
marked this pull request as ready for review
December 5, 2024 12:31
dackers86
reviewed
Dec 5, 2024
Comment thread
src/firebase_functions/private/_identity_fn.py
| @@ -351,9 +358,9 @@ def before_operation_handler( | |||
| raise HttpsError(FunctionsErrorCode.INVALID_ARGUMENT, "Bad Request") | |||
| jwt_token = request.json["data"]["jwt"] | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should we be checking if jwt is undefined here?
Sorry, something went wrong.
pr-Mais
reviewed
Dec 5, 2024
Comment thread
samples/identity/functions/requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.